Remove pylint

Pylint is useful but quite slow. Ruff covers most of the pylint checks,
but finishes in an instant.

Author: holesch

.github/workflows/on-push.yml

@@ -27,8 +27,6 @@ jobs:
     - name: Install dependencies
       run: |
         pip install .[test]
-    - name: Lint with Pylint
-      run: pylint --score=n not_my_board tests
     - name: Check format with Black
       run: black --check --quiet not_my_board tests doc
     - name: Check import statement order with isort

not_my_board/_agent.py

@@ -255,7 +255,6 @@ def _filter_places(import_description, places):
     return candidates
 
 
-# pylint: disable=too-many-locals
 def _create_tunnel_descriptions(import_description, place, matching):
     place_name = import_description.name
     proxy = (place.host, place.port)

not_my_board/_auth/_login.py

@@ -97,7 +97,6 @@ def __init__(self, path_str=None):
         self._path = path
 
     async def _context_stack(self, stack):
-        # pylint: disable-next=consider-using-with  # false positive
         self._f = stack.enter_context(self._path.open("r+"))
         await stack.enter_async_context(util.flock(self._f))
         content = self._f.read()

not_my_board/_http.py

@@ -437,7 +437,6 @@ def _is_proxy_disabled_host(host, patterns):
     return False
 
 
-# pylint: disable=protected-access
 # remove, if Python version < 3.11 is no longer supported
 async def _start_tls(writer, url):
     if hasattr(writer, "start_tls"):

not_my_board/_hub.py

@@ -37,8 +37,6 @@ async def asgi_app(scope, receive, send):
         # before handing over to asgineer
         await _handle_lifespan(scope, receive, send)
     else:
-        # to_asgi() decorator adds extra arguments
-        # pylint: disable-next=too-many-function-args
         await _handle_request(scope, receive, send)
 
 
@@ -114,7 +112,6 @@ async def require_role_wrapper(*args, **kwargs):
 
 
 class Hub:
-    # pylint: disable=too-many-locals
     def __init__(self, config=None, http_client=None):
         self._places = {}
         self._exporters = {}

not_my_board/_jsonrpc/_protocol.py

@@ -217,7 +217,6 @@ def hidden(func):
     keep it public for local users, otherwise just use a leading underscore in
     the method name.
     """
-    # pylint: disable=protected-access
     func._jsonrpc_hidden = True
     return func
 

not_my_board/_usbip.py

@@ -371,9 +371,6 @@ def __class_getitem__(cls, key):
         return Annotated[bytes, StructStr(f"{key}s")]
 
 
-# pylint: disable=W0212,E1101
-# - accessing protected member of cls, e.g. cls._struct
-# - 'serializable' has no '_struct' member
 def serializable(cls):
     cls = dataclasses.dataclass(cls)
 
@@ -414,8 +411,6 @@ async def from_reader(cls, reader):
                     f"Expected {field.name}={field.default}, got={value}"
                 )
 
-        # pylint: disable=E1120
-        # No value for argument 'cls': false positive
         return cls(*init_values)
 
     cls.__bytes__ = __bytes__
@@ -424,7 +419,6 @@ async def from_reader(cls, reader):
     return cls
 
 
-# pylint: disable=invalid-field-call
 def no_init(default):
     return dataclasses.field(default=default, init=False)
 
@@ -502,7 +496,6 @@ async def _open_read_pipe(*args, **kwargs):
         yield reader
 
 
-# pylint: disable=import-outside-toplevel
 async def _main():
     import argparse
 

not_my_board/_util/_matching.py

@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name
 # ruff: noqa: N803
 # ruff: noqa: N806
 import collections

not_my_board/cli/__init__.py

@@ -23,7 +23,6 @@
 TOKEN_STORE_PATH = "/var/lib/not-my-board/auth_tokens.json"  # noqa: S105
 
 
-# pylint: disable=too-many-statements
 # ruff: noqa: PLR0915
 def main():
     parser = argparse.ArgumentParser(description="Setup, manage and use a board farm")

pyproject.toml

@@ -52,8 +52,6 @@ test = [
     "codespell",
     "isort",
     "mypy",
-    "pylint",
-    "pylint-pytest",
     "pytest",
     "pytest-asyncio ~= 0.21.2",
     "pytest-cov",
@@ -76,40 +74,6 @@ addopts = ["--quiet"]
 testpaths = ["tests"]
 asyncio_mode = "auto"
 
-[tool.pylint.MASTER]
-load-plugins = "pylint_pytest"
-
-[tool.pylint."MESSAGES CONTROL"]
-disable = [
-    "attribute-defined-outside-init",
-    "broad-exception-caught",
-    "contextmanager-generator-missing-cleanup",
-    "fixme",
-    "missing-class-docstring",
-    "missing-function-docstring",
-    "missing-module-docstring",
-    "no-else-raise",
-    "no-else-return",
-    "too-few-public-methods",
-    "too-many-arguments",
-    "too-many-instance-attributes",
-    "unspecified-encoding",
-]
-# allow short names
-variable-rgx = "^_{,2}[a-z][a-z0-9_]{,30}$"
-argument-rgx = "^_{,2}[a-z][a-z0-9_]{,30}$"
-attr-rgx = "^_{,2}[a-z][a-z0-9_]{,30}$"
-# allow any length for functions (e.g. test function names can be quite
-# long)
-function-rgx = "^_{,2}[a-z][a-z0-9_]*$"
-# pylint doesn't support lazy_import()
-generated-members = [
-    "websockets",
-    "pydantic",
-    "ImportRequest",
-    "ImportReply",
-]
-
 [tool.isort]
 profile = "black"
 

tests/test_hub.py

@@ -58,7 +58,6 @@ def allowed_ips(self):
         return self._allowed_ips
 
 
-# pylint: disable=redefined-outer-name
 @contextlib.asynccontextmanager
 async def register_exporter(hub, ip=DEFAULT_EXPORTER_IP):
     rpc1, rpc2 = fake_rpc_pair()
@@ -82,7 +81,6 @@ async def test_register_exporter(hub):
     assert len(places["places"]) == 0
 
 
-# pylint: disable=redefined-outer-name
 @contextlib.asynccontextmanager
 async def register_agent(hub, ip=DEFAULT_AGENT_IP):
     rpc1, rpc2 = fake_rpc_pair()

tests/test_jsonrpc.py

@@ -309,7 +309,6 @@ async def test_either_args_or_kwargs(fakes):
 
 async def test_prevent_hidden_function_call(fakes):
     with pytest.raises(AttributeError) as execinfo:
-        # pylint: disable=protected-access
         await fakes.channel._hidden()
     assert "invalid attribute" in str(execinfo.value)