Skip to content

Link xxhash with pkg-config #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Link xxhash with pkg-config #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libyang3-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ fn main() {
if let Ok(lib) = pkg_config::Config::new().probe("libpcre2-8") {
include_paths = lib.include_paths.clone();
}
if let Ok(lib) = pkg_config::Config::new().probe("libxxhash") {
include_paths.extend(lib.include_paths.clone());
}
// Add libyang include paths if found in pkg-config
if let Ok(lib) = pkg_config::Config::new().probe("libyang") {
include_paths.extend(lib.include_paths.clone());
Expand Down Expand Up @@ -74,6 +77,12 @@ fn main() {
println!("cargo:warning=attempting to link without pkg-config");
println!("cargo:rustc-link-lib=pcre2-8");
}
if let Err(e) = pkg_config::Config::new().probe("libxxhash") {
println!("cargo:warning=failed to find xxhash library with pkg-config: {}", e);
Copy link
Member

@rwestphal rwestphal Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the warning, will the build script work ok if xxhash is not found? I see it is an optional libyang dependency, so I would prefer not to make it a mandatory dependency here.

println!(
"cargo:warning=attempting to link xxhash without pkg-config"
);
}
println!("cargo:rustc-link-lib=static=yang");
println!("cargo:rerun-if-changed=libyang");
}
Expand Down
Loading