Don't show all elements if nothing is selected by visibile (#133)

Author: hoxbro

holonote/annotate/annotator.py

@@ -321,7 +321,7 @@ class Annotator(AnnotatorInterface):
 
     groupby = param.Selector(default=None, doc="Groupby dimension", allow_refs=True)
     visible = param.ListSelector(
-        default=[], doc="Visible dimensions, needs groupby enabled", allow_refs=True
+        default=None, doc="Visible dimensions, needs groupby enabled", allow_refs=True
     )
     style = param.ClassSelector(default=Style(), class_=Style, doc="Style parameters")
 

holonote/annotate/display.py

@@ -537,8 +537,14 @@ def static_indicators(self, **events):
             msg = f"{self.region_format} not implemented"
             raise NotImplementedError(msg)
 
-        if len(indicator.data) == 0:
-            return hv.NdOverlay({0: self._make_empty_element()})
+        if len(indicator.data) == 0 or (
+            self.annotator.groupby
+            and self.annotator.visible is not None
+            and not len(self.annotator.visible)
+        ):
+            el = self._make_empty_element()
+            el_opts = getattr(hv.opts, type(el).__name__)(**_default_opts)
+            return hv.NdOverlay({0: el}).opts(el_opts)
 
         if self.annotator.groupby and self.annotator.visible:
             indicator = indicator.get(self.annotator.visible)

holonote/tests/test_annotators_element.py

@@ -37,7 +37,7 @@ def test_set_regions_range1d(annotator_range1d) -> None:
     expected = [None, None]
     assert output == expected
 
-    output = next(get_indicator_data(annotator, hv.Rectangles))
+    output = next(get_indicator_data(annotator, hv.VSpans))
     output1 = output.iloc[0][["start[TIME]", "end[TIME]"]].tolist()
     expected1 = [-0.25, 0.25]
     assert output1 == expected1
@@ -115,7 +115,7 @@ def test_set_regions_multiple(multiple_annotators):
     expected = [None, None]
     assert output == expected
 
-    output = next(get_indicator_data(annotator, hv.Rectangles, "TIME"))
+    output = next(get_indicator_data(annotator, hv.VSpans, "TIME"))
     output1 = output.iloc[0][["start[TIME]", "end[TIME]"]].tolist()
     expected1 = [-0.25, 0.25]
     assert output1 == expected1
@@ -251,6 +251,14 @@ def test_groupby_visible(cat_annotator):
         next(iter_indicator)
 
 
+def test_groupby_visible_empty(cat_annotator):
+    cat_annotator.groupby = "category"
+    cat_annotator.visible = []
+    iter_indicator = get_indicator(cat_annotator, hv.Curve)
+    indicator = next(iter_indicator)
+    assert indicator.data.shape == (0, 2)
+
+
 def test_groupby_with_overlay_from_empty_annotator(annotator_range2d, capsys):
     # Test for https://github.com/holoviz/holonote/issues/119
     annotator = annotator_range2d

holonote/tests/test_annotators_style.py

@@ -38,7 +38,7 @@ def compare_style(cat_annotator):
 
 
 def get_selected_indicator_data(annotator) -> pd.Series:
-    df = pd.concat([i.data for i in get_indicator(annotator, hv.VLines)])
+    df = pd.concat([i.data for i in get_indicator(annotator, None)])
     return df["__selected__"]
 
 

holonote/tests/util.py

@@ -26,7 +26,10 @@ def get_editor_data(annotator, element_type, kdims=None):
 
 def get_indicator(annotator, element_type, kdims=None):
     si = _get_display(annotator, kdims).indicators().last
-    yield from si.data.values()
+    if element_type:
+        yield from (s for s in si.data.values() if isinstance(s, element_type))
+    else:
+        yield from si.data.values()
 
 
 def get_indicator_data(annotator, element_type, kdims=None):

pyproject.toml

@@ -48,6 +48,8 @@ filterwarnings = [
     "ignore:datetime.datetime.utcfromtimestamp():DeprecationWarning:dateutil.tz.tz", # https://github.com/dateutil/dateutil/pull/1285
     # 2024-01
     "ignore:\\s+Pyarrow will become a required dependency of pandas", # Will fix itself
+    # 2024-09
+    "ignore:The (non_)?interactive_bk attribute was deprecated in Matplotlib 3.9", # OK - Only happening in debug mode
 ]
 
 [tool.ruff]