Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More readable Ingress diff #402

Open
Gelmir opened this issue Sep 5, 2024 · 2 comments
Open

More readable Ingress diff #402

Gelmir opened this issue Sep 5, 2024 · 2 comments

Comments

@Gelmir
Copy link

Gelmir commented Sep 5, 2024

Would if be possible to use some different color to highlight changes in lists?

After changing only path in k8s Ingress:

dyff --color on between --omit-header output:
изображение

diff --color -uN output:
изображение

As you can see, catching changes with dyff here is quite troublesome, because colors are the same.
Using dyff version 1.9.0

@HeavyWombat
Copy link
Member

Thanks for bringing it up. This is one of the oldest problems in dyff that I wanted to solve for some time now. In this case, diff works on a line basis sort of, while dyff is always using the YAML semantics. It's detecting an entry that most likely is identified by the path field and therefore considers the entries in before and after as completely different. One would need some clever code to detect that only the path has changed and this is indeed the same entry from a human point of view.

@dudicoco
Copy link

dudicoco commented Feb 3, 2025

@HeavyWombat perhaps you could add another layer of diff detection on top such as Git Delta to detect changed words/lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants