New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in determining `done` in `env.step`? #49

Open

ArchieGertsman opened this issue Jan 22, 2023 · 0 comments

ArchieGertsman commented Jan 22, 2023

decima-sim/spark_env/env.py

Lines 338 to 341 in c010dd7

    
           # no more decision to make, jobs all done or time is up 
        
           done = (self.num_source_exec == 0) and \ 
        
                  ((len(self.timeline) == 0) or \ 
        
                  (self.wall_time.curr_time >= self.max_time))

I believe this logic is wrong, and the intended logic is as follows:

done = (self.num_source_exec == 0 and len(self.timeline) == 0) or \
       self.wall_time.curr_time >= self.max_time

The way it's currently written allows the environment to keep going way past the max time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment