Merge pull request #23 from nutama/php7.4

php 7.4 compatibility

Author: nutama

.travis.yml

@@ -1,10 +1,7 @@
 language: php
 php:
+  - 7.4
   - 7.3
-  - 7.2
-  - 7.1
-  - 7.0
-  - 5.6
 
 before_script:
     - composer install --dev

lib/cache/sfFileCache.class.php

@@ -215,8 +215,7 @@ protected function read($path, $type = self::READ_DATA)
     @flock($fp, LOCK_SH);
     clearstatcache(); // because the filesize can be cached by PHP itself...
     $length = @filesize($path);
-    $mqr = get_magic_quotes_runtime();
-    set_magic_quotes_runtime(0);
+
     switch ($type)
     {
       case self::READ_TIMEOUT:
@@ -240,7 +239,6 @@ protected function read($path, $type = self::READ_DATA)
       default:
         throw new sfConfigurationException(sprintf('Unknown type "%s".', $type));
     }
-    set_magic_quotes_runtime($mqr);
     @flock($fp, LOCK_UN);
     @fclose($fp);
 

lib/helper/UrlHelper.php

@@ -471,7 +471,7 @@ function _encodeText($text)
 
   for ($i = 0; $i < strlen($text); $i++)
   {
-    $char = $text{$i};
+    $char = $text[$i];
     $r = rand(0, 100);
 
     # roughly 10% raw, 45% hex, 45% dec

lib/i18n/sfDateFormat.class.php

@@ -221,7 +221,7 @@ public function format($time, $pattern = 'F', $inputPattern = null, $charset = '
     for ($i = 0, $max = count($tokens); $i < $max; $i++)
     {
       $pattern = $tokens[$i];
-      if ($pattern{0} == "'" && $pattern{strlen($pattern) - 1} == "'")
+      if ($pattern[0] == "'" && $pattern[strlen($pattern) - 1] == "'")
       {
         $tokens[$i] = str_replace('``````', '\'', preg_replace('/(^\')|(\'$)/', '', $pattern));
       }
@@ -258,9 +258,9 @@ public function format($time, $pattern = 'F', $inputPattern = null, $charset = '
    */
   protected function getFunctionName($token)
   {
-    if (isset($this->tokens[$token{0}]))
+    if (isset($this->tokens[$token[0]]))
     {
-      return $this->tokens[$token{0}];
+      return $this->tokens[$token[0]];
     }
   }
 
@@ -389,30 +389,30 @@ protected function getTokens($pattern)
 
     for ($i = 0, $max = strlen($pattern); $i < $max; $i++)
     {
-      if ($char == null || $pattern{$i} == $char || $text)
+      if ($char == null || $pattern[$i] == $char || $text)
       {
-        $token .= $pattern{$i};
+        $token .= $pattern[$i];
       }
       else
       {
         $tokens[] = str_replace("''", "'", $token);
-        $token = $pattern{$i};
+        $token = $pattern[$i];
       }
 
-      if ($pattern{$i} == "'" && $text == false)
+      if ($pattern[$i] == "'" && $text == false)
       {
         $text = true;
       }
-      else if ($text && $pattern{$i} == "'" && $char == "'")
+      else if ($text && $pattern[$i] == "'" && $char == "'")
       {
         $text = true;
       }
-      else if ($text && $char != "'" && $pattern{$i} == "'")
+      else if ($text && $char != "'" && $pattern[$i] == "'")
       {
         $text = false;
       }
 
-      $char = $pattern{$i};
+      $char = $pattern[$i];
 
     }
     $tokens[] = $token;

lib/i18n/sfNumberFormat.class.php

@@ -204,7 +204,7 @@ protected function formatInteger($string)
       // now for the integer groupings
       for ($i = 0; $i < $len; $i++)
       {
-        $char = $string{$len - $i - 1};
+        $char = $string[$len - $i - 1];
 
         if ($multiGroup && $count == 0)
         {

lib/i18n/sfNumberFormatInfo.class.php

@@ -311,7 +311,7 @@ protected function parsePattern($pattern)
         // to find the groupsize 1.
         for ($i = strlen($pattern) - 1; $i >= 0; $i--)
         {
-          if ($pattern{$i} == $digit || $pattern{$i} == $hash)
+          if ($pattern[$i] == $digit || $pattern[$i] == $hash)
           {
             $groupSize1 = $i - $groupPos1;
             break;
@@ -330,11 +330,11 @@ protected function parsePattern($pattern)
     {
       for ($i = strlen($pattern) - 1; $i >= 0; $i--)
       {
-        if ($pattern{$i} == $dot)
+        if ($pattern[$i] == $dot)
         {
           break;
         }
-        if ($pattern{$i} == $digit)
+        if ($pattern[$i] == $digit)
         {
           $decimalPoints = $i - $decimalPos;
           break;

lib/plugins/sfPropelPlugin/lib/vendor/creole/drivers/pgsql/PgSQLResultSet.php

@@ -137,7 +137,7 @@ private function strToArray($str)
 					$res[] = $this->strToArray(implode(',', $subarr[$in_subarr]));
 					$in_subarr--;
 				}
-			} elseif ($tok{0} === '{') { // we're inside a new sub-array							   
+			} elseif ($tok[0] === '{') { // we're inside a new sub-array
 				if ('}' !== substr($tok, -1, 1)) {
 					$in_subarr++;
 					// if sub-array has more than one element

lib/plugins/sfPropelPlugin/lib/vendor/creole/util/sql/SQLStatementExtractor.php

@@ -143,7 +143,7 @@ protected static function substring($string, $startpos, $endpos = -1) {
             trigger_error("substring(), Endindex out of bounds must be $startpos<n<".($len-1), E_USER_ERROR);
         }
         if ($startpos === $endpos) {
-            return (string) $string{$startpos};
+            return (string) $string[$startpos];
         } else {
             $len = $endpos-$startpos;
         }

lib/plugins/sfPropelPlugin/lib/vendor/phing/Phing.php

@@ -916,7 +916,7 @@ public static function getResourcePath($path) {
         // This is a bit of a hack, but works better than previous solution of assuming
         // data_dir is on the include_path.
         $data_dir = '@DATA-DIR@';
-        if ($data_dir{0} != '@') { // if we're using PEAR then the @ DATA-DIR @ token will have been substituted.
+        if ($data_dir[0] != '@') { // if we're using PEAR then the @ DATA-DIR @ token will have been substituted.
             $data_path = $data_dir . DIRECTORY_SEPARATOR . $path;
             if (file_exists($data_path)) {
                    return $data_path;

lib/plugins/sfPropelPlugin/lib/vendor/phing/lib/Capsule.php

@@ -183,9 +183,9 @@ function parse($template, $outputFile = null, $append = false) {
      * @return string "Best guess" path for this file.
      */
     protected function resolvePath($file, $basepath) {
-        if ( !($file{0} == DIRECTORY_SEPARATOR || $file{0} == '/') 
+        if ( !($file[0] == DIRECTORY_SEPARATOR || $file[0] == '/')
             // also account for C:\ style path
-                && !($file{1} == ':' && ($file{2} ==  DIRECTORY_SEPARATOR || $file{2} == '/'))) { 
+                && !($file[1] == ':' && ($file[2] ==  DIRECTORY_SEPARATOR || $file[2] == '/'))) {
             if ($basepath != null) {
                 $file = $basepath . DIRECTORY_SEPARATOR . $file;
             }