Skip to content

Commit 5dc9cd0

Browse files
authored
Merge pull request #490 from R-Sourabh/#488-bopis-cancellation-reasons
Improved: Removed the Shopify cancellation reason and added logic to fetch the cancellation reason from the enum group(#488)
2 parents 0d710b5 + f1909ac commit 5dc9cd0

File tree

7 files changed

+15
-12
lines changed

7 files changed

+15
-12
lines changed

src/components/ConfirmCancelModal.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export default defineComponent({
134134
},
135135
getCancelReasonDescription(cancelReasonId: string) {
136136
const reason = this.cancelReasons?.find((reason: any) => reason.enumId === cancelReasonId)
137-
return reason?.description ? reason.description : reason?.enumDescription ? reason.enumDescription : reason?.enumId;
137+
return reason?.enumDescription ? reason.enumDescription : reason?.enumId;
138138
},
139139
async cancelOrder() {
140140
emitter.emit("presentLoader");

src/components/ReportAnIssuePopover.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</ion-list>
88
<ion-list v-else>
99
<ion-item v-for="reason in cancelReasons" :key="reason.enumId" @click="updateIssue(reason.enumId)" button>
10-
{{ reason.description ? translate(reason.description) : reason.enumDescription ? translate(reason.enumDescription) : reason.enumId }}
10+
{{ reason.enumDescription ? translate(reason.enumDescription) : reason.enumId }}
1111
</ion-item>
1212
</ion-list>
1313
</ion-content>

src/locales/en.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"Assign Pickers": "Assign Pickers",
1717
"Assigned for fulfillment": "Assigned for fulfillment",
1818
"Authorized": "Authorized",
19+
"Bad review from friends/relatives": "Bad review from friends/relatives",
1920
"Browser TimeZone": "Browser TimeZone",
2021
"Browser time zone": "Browser time zone",
2122
"Catalog": "Catalog",
@@ -31,7 +32,7 @@
3132
"carrier": "carrier",
3233
"Control what your customers are allowed to edit on their order when they are editing their order on Re-route Fulfillment.": "Control what your customers are allowed to edit on their order when they are editing their order on Re-route Fulfillment.",
3334
"Change": "Change",
34-
"Changed Mind": "Changed Mind",
35+
"Changed my mind": "Changed my mind",
3536
"Choose language": "Choose language",
3637
"City": "City",
3738
"Click the backdrop to dismiss.": "Click the backdrop to dismiss.",
@@ -120,6 +121,7 @@
120121
"On rejecting this order, will be sent an email with alternate fulfilment options and this order will be removed from your dashboard.": "On rejecting this order, { customerName } will be sent an email with alternate fulfilment options and this order will be removed from your dashboard.",
121122
"Online ATP": "Online ATP",
122123
"on hand": "{ count } on hand",
124+
"Other": "Other",
123125
"Other stores inventory": "Other stores inventory",
124126
"Order": "Order",
125127
"Order completed": "Order completed",
@@ -215,7 +217,6 @@
215217
"Shipping to store": "Shipping to store",
216218
"Ship to this address": "Ship to this address",
217219
"Shop": "Shop",
218-
"Shopify Cancellation": "Shopify Cancellation",
219220
"Show shipping orders": "Show shipping orders",
220221
"Showing the next estimated time to sync cancelation to Shopify": "Showing the next estimated time to sync cancelation to Shopify",
221222
"Size:": "Size: {size}",

src/locales/es.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"Assign Pickers": "Asignar recolectores",
1717
"Assigned for fulfillment": "Assigned for fulfillment",
1818
"Authorized": "Authorized",
19+
"Bad review from friends/relatives": "Bad review from friends/relatives",
1920
"Browser TimeZone": "Browser TimeZone",
2021
"Browser time zone": "Browser time zone",
2122
"Catalog": "Catálogo",
@@ -31,7 +32,7 @@
3132
"carrier": "carrier",
3233
"Control what your customers are allowed to edit on their order when they are editing their order on Re-route Fulfillment.": "Controle lo que sus clientes pueden editar en su pedido cuando editan su pedido en Reenrutar el cumplimiento.",
3334
"Change": "Cambiar",
34-
"Changed Mind": "Changed Mind",
35+
"Changed my mind": "Changed my mind",
3536
"Choose language": "Elegir idioma",
3637
"City": "Ciudad",
3738
"Click the backdrop to dismiss.": "Haz clic en el fondo para cerrar.",
@@ -118,6 +119,7 @@
118119
"On rejecting this order, will be sent an email with alternate fulfilment options and this order will be removed from your dashboard.": "Al rechazar este pedido, {customerName} recibirá un correo electrónico con opciones de cumplimiento alternativas y este pedido se eliminará de su panel.",
119120
"Online ATP": "Online ATP",
120121
"on hand": "{ count } on hand",
122+
"Other": "Other",
121123
"Other stores inventory": "Inventario de otras tiendas",
122124
"Order": "Orden",
123125
"Order completed": "Order completed",
@@ -213,7 +215,6 @@
213215
"Shipping to store": "Envío a la tienda",
214216
"Ship to this address": "Enviar a esta dirección",
215217
"Shop": "Comprar",
216-
"Shopify Cancellation": "Shopify Cancellation",
217218
"Show shipping orders": "Mostrar órdenes de envío",
218219
"Showing the next estimated time to sync cancelation to Shopify": "Showing the next estimated time to sync cancelation to Shopify",
219220
"Sizes": "Tamaños",

src/locales/ja.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"Assign Pickers": "受け取り人の割当",
1616
"Assigned for fulfillment": "Assigned for fulfillment",
1717
"Authorized": "Authorized",
18+
"Bad review from friends/relatives": "Bad review from friends/relatives",
1819
"Browser TimeZone": "ブラウザーのタイムゾーン",
1920
"Browser time zone": "ブラウザーのタイムゾーン",
2021
"Catalog": "カタログ",
@@ -30,7 +31,7 @@
3031
"carrier": "carrier",
3132
"Control what your customers are allowed to edit on their order when they are editing their order on Re-route Fulfillment.": "お客様がリルート(受取方法や受取場所の変更)で注文を編集する際に、注文の編集を許可する内容を制御します。",
3233
"Change": "変更",
33-
"Changed Mind": "Changed Mind",
34+
"Changed my mind": "Changed my mind",
3435
"Choose language": "言語を選択",
3536
"City": "",
3637
"Click the backdrop to dismiss.": "背景をクリックして閉じます。",
@@ -114,6 +115,7 @@
114115
"On rejecting this order, will be sent an email with alternate fulfilment options and this order will be removed from your dashboard.": "この注文を拒否すると、{customerName} に代替の配送オプションを含むメールが送信され、この注文はダッシュボードから削除されます。",
115116
"Online ATP": "Online ATP",
116117
"on hand": "{count} 在庫あり",
118+
"Other": "Other",
117119
"Other stores inventory": "その他店舗在庫",
118120
"Order": "注文",
119121
"Order completed": "Order completed",
@@ -206,7 +208,6 @@
206208
"Shipping to store": "店舗に配送",
207209
"Ship to this address": "この住所に配送",
208210
"Shop": "ショップ",
209-
"Shopify Cancellation": "Shopify Cancellation",
210211
"Show shipping orders": "出荷オーダーの表示",
211212
"Showing the next estimated time to sync cancelation to Shopify": "Showing the next estimated time to sync cancelation to Shopify",
212213
"Sizes": "サイズ",

src/store/modules/util/actions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ const actions: ActionTree<UtilState, RootState> = {
9191
let cancelReasons = [];
9292
const payload = {
9393
"inputFields": {
94-
"enumTypeId": "ODR_ITM_CH_REASON"
94+
"enumerationGroupId": "BOPIS_CNCL_RES"
9595
},
96-
"fieldList": ["enumId", "description"],
97-
"entityName": "Enumeration",
96+
"fieldList": ["enumId", "enumDescription"],
97+
"entityName": "EnumerationGroupAndMember",
9898
"distinct": "Y",
9999
"viewSize": 100,
100100
"orderBy": "sequenceNum"

src/views/OrderDetailUpdated.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -799,7 +799,7 @@ export default defineComponent({
799799
},
800800
getCancelReasonDescription(cancelReasonId: string) {
801801
const reason = this.cancelReasons?.find((reason: any) => reason.enumId === cancelReasonId)
802-
return reason?.description ? reason.description : reason?.enumDescription ? reason.enumDescription : reason?.enumId;
802+
return reason?.enumDescription ? reason.enumDescription : reason?.enumId;
803803
},
804804
isEntierOrderRejectionEnabled(order: any) {
805805
return (!this.partialOrderRejectionConfig || !this.partialOrderRejectionConfig.settingValue || !JSON.parse(this.partialOrderRejectionConfig.settingValue)) && this.hasRejectedItems

0 commit comments

Comments
 (0)