Improved: mutation names for maargjob store, updated env entry name for maarg job enums (#734)

Author: amansinghbais

.env.example

@@ -18,11 +18,11 @@ VUE_APP_ALIAS=
 VUE_APP_DEFAULT_LOG_LEVEL="error"
 VUE_APP_LOGIN_URL="http://launchpad.hotwax.io/login"
 VUE_APP_BROKER_JOB_ENUMS = {"REJ_ORDR":"JOB_BKR_REJ_ORD"}
-VUE_APP_FULFILLMENT_MAARG_JOB_NAMES={"SND_FF_ACK_FEED":"SND_SHPFY_FUL_ACK_FD","GNRT_FF_ORD_ITM_FEED":"GEN_FLFLD_ORD_ITM_FD", "POL_OMS_FLFLMNT_FEED": "POL_OMS_FLFLMNT_FD"}
-VUE_APP_INVENTORY_MAARG_JOB_NAMES={"GEN_TO_RCPT_FEED":"GEN_TO_RCPT_FD","GEN_INV_VAR_FEED":"GEN_INV_VAR_FD", "GEN_INVCYC_COUNT_VAR_FEED": "GEN_INV_CYCLE_VAR_FD", "POLL_OMS_FULFIL_FEED": "POL_OMS_FLFLMNT_FD"}
-VUE_APP_ORDERS_MAARG_JOB_NAMES={"GEN_BRKD_ORDITM_FEED":"GEN_BRKR_ORD_ITM_FD","GEN_APPEASE_FIN_FEED":"GEN_APSMNT_FNCL_FD", "GEN_RTRN_FIN_FEED": "GEN_RTNS_FNCL_FD"}
-VUE_APP_MISC_MAARG_JOB_NAMES={"BLK_SYS_MESS_SHPFY": "SND_BLK_SYS_M_SHPFY","BLK_RSLT_SHPFY":"POL_BLK_RSLT_SHPFY"}
-VUE_APP_PREORD_MAARG_JOB_NAMES={"PO_RCPT_FEED": "GEN_PO_RCPT_FD"}
+VUE_APP_FULFILLMENT_MAARG_JOB_ENUMS={"SND_FF_ACK_FEED":"SND_SHPFY_FUL_ACK_FD","GNRT_FF_ORD_ITM_FEED":"GEN_FLFLD_ORD_ITM_FD", "POL_OMS_FLFLMNT_FEED": "POL_OMS_FLFLMNT_FD"}
+VUE_APP_INVENTORY_MAARG_JOB_ENUMS={"GEN_TO_RCPT_FEED":"GEN_TO_RCPT_FD","GEN_INV_VAR_FEED":"GEN_INV_VAR_FD", "GEN_INVCYC_COUNT_VAR_FEED": "GEN_INV_CYCLE_VAR_FD", "POLL_OMS_FULFIL_FEED": "POL_OMS_FLFLMNT_FD"}
+VUE_APP_ORDERS_MAARG_JOB_ENUMS={"GEN_BRKD_ORDITM_FEED":"GEN_BRKR_ORD_ITM_FD","GEN_APPEASE_FIN_FEED":"GEN_APSMNT_FNCL_FD", "GEN_RTRN_FIN_FEED": "GEN_RTNS_FNCL_FD"}
+VUE_APP_MISC_MAARG_JOB_ENUMS={"BLK_SYS_MESS_SHPFY": "SND_BLK_SYS_M_SHPFY","BLK_RSLT_SHPFY":"POL_BLK_RSLT_SHPFY"}
+VUE_APP_PREORD_MAARG_JOB_ENUMS={"PO_RCPT_FEED": "GEN_PO_RCPT_FD"}
 VUE_APP_CRON_EXPRESSIONS={"Every 5 minutes":"0 */5 * ? * *","Every 15 minutes":"0 */15 * ? * *","Every 30 minutes":"0 */30 * ? * *","Hourly":"0 0 * ? * *","Every six hours":"0 0 */6 ? * *","Every day at midnight":"0 0 0 * * ?"}
 VUE_APP_GITBOOK_API_KEY=""
 VUE_APP_SPACE_ID=""

src/services/MaargJobService.ts

@@ -88,7 +88,7 @@ const fetchMaargJobEnumerations = async (payload: any): Promise <any>  => {
   const updatedBaseUrl = baseURL.replace("admin", "available-to-promise")
 
   return client({
-    url: `enums`,
+    url: "enums",
     method: "GET",
     baseURL,
     params: payload,

src/store/modules/maargJob/actions.ts

@@ -51,7 +51,7 @@ const actions: ActionTree<JobState, RootState> = {
       logger.error(error);
     }
 
-    commit(types.MAARGJOB_MAARG_JOBS_UPDATED, maargJobs);
+    commit(types.MAARGJOB_UPDATED, maargJobs);
   },
 
   async updateMaargJob({ commit, state }, jobEnumId) {
@@ -70,8 +70,8 @@ const actions: ActionTree<JobState, RootState> = {
         currentJob["parameterValues"] = paramValue
 
         jobs[jobEnumId] = currentJob
-        commit(types.MAARGJOB_MAARG_JOBS_UPDATED, jobs);
-        commit(types.MAARGJOB_CURRENT_JOB_UPDATED, currentJob);
+        commit(types.MAARGJOB_UPDATED, jobs);
+        commit(types.MAARGJOB_CURRENT_UPDATED, currentJob);
       } else {
         throw resp;
       }
@@ -99,20 +99,20 @@ const actions: ActionTree<JobState, RootState> = {
     } catch(error) {
       logger.error(error);
     }
-    commit(types.MAARGJOB_JOB_ENUMS_UPDATED, jobEnums);
+    commit(types.MAARGJOB_ENUMS_UPDATED, jobEnums);
   },
 
   async updateCurrentMaargJob({ commit }, payload) {
     if(payload?.job) {
-      commit(types.MAARGJOB_CURRENT_JOB_UPDATED, payload.job);
+      commit(types.MAARGJOB_CURRENT_UPDATED, payload.job);
       return payload?.job;
     }
 
     // Todo: refetch job for the mobile view of job details.
   },
 
   async clearMaargJobState({ commit }) {
-    commit(types.MAARGJOB_JOB_ENUMS_UPDATED, {});
+    commit(types.MAARGJOB_ENUMS_UPDATED, {});
   }
 }
 export default actions;

src/store/modules/maargJob/mutation-types.ts

@@ -1,6 +1,6 @@
 export const SN_MAARGJOB = 'maargJob'
 export const MAARGJOB_UPDATED_BULK = SN_MAARGJOB + '/UPDATED_BULK'
-export const MAARGJOB_MAARG_JOBS_UPDATED = SN_MAARGJOB + '/MAARG_JOBS_UPDATED'
-export const MAARGJOB_CURRENT_JOB_UPDATED = SN_MAARGJOB + '/CURRENT_JOB_UPDATED'
-export const MAARGJOB_JOB_ENUMS_UPDATED = SN_MAARGJOB + '/JOB_ENUMS_UPDATED'
+export const MAARGJOB_UPDATED = SN_MAARGJOB + '/MAARG_JOBS_UPDATED'
+export const MAARGJOB_CURRENT_UPDATED = SN_MAARGJOB + '/CURRENT_JOB_UPDATED'
+export const MAARGJOB_ENUMS_UPDATED = SN_MAARGJOB + '/JOB_ENUMS_UPDATED'
 

src/store/modules/maargJob/mutations.ts

@@ -3,13 +3,13 @@ import MaargJobState from './MaargJobState'
 import * as types from './mutation-types'
 
 const mutations: MutationTree <MaargJobState> = {
-  [types.MAARGJOB_MAARG_JOBS_UPDATED] (state, payload) {
+  [types.MAARGJOB_UPDATED] (state, payload) {
     state.maargJobs = payload
   },
-  [types.MAARGJOB_CURRENT_JOB_UPDATED] (state, payload) {
+  [types.MAARGJOB_CURRENT_UPDATED] (state, payload) {
     state.currentMaargJob = payload
   },
-  [types.MAARGJOB_JOB_ENUMS_UPDATED] (state, payload) {
+  [types.MAARGJOB_ENUMS_UPDATED] (state, payload) {
     state.maargJobEnums = payload
   },
 }

src/views/Fulfillment.vue

@@ -195,7 +195,7 @@ export default defineComponent({
       autoCancelDays: '',
       enumTypeId: 'FULFILLMENT_SYS_JOB',
       initialLoadJobEnums: JSON.parse(process.env?.VUE_APP_INITIAL_JOB_ENUMS as string) as any,
-      maargJobEnums: JSON.parse(process.env.VUE_APP_FULFILLMENT_MAARG_JOB_NAMES as string) as any,
+      maargJobEnums: JSON.parse(process.env.VUE_APP_FULFILLMENT_MAARG_JOB_ENUMS as string) as any,
       isLoading: false
     }
   },

src/views/Inventory.vue

@@ -125,7 +125,7 @@ export default defineComponent({
       isDesktop: isPlatform('desktop'),
       enumTypeId: 'INVENTORY_SYS_JOB',
       webhookEnums: JSON.parse(process.env?.VUE_APP_WEBHOOK_ENUMS as string) as any,
-      maargJobEnums: JSON.parse(process.env.VUE_APP_INVENTORY_MAARG_JOB_NAMES as string) as any,
+      maargJobEnums: JSON.parse(process.env.VUE_APP_INVENTORY_MAARG_JOB_ENUMS as string) as any,
       isLoading: false
     }
   },

src/views/Miscellaneous.vue

@@ -132,7 +132,7 @@ export default defineComponent({
       isJobDetailAnimationCompleted: false,
       isDesktop: isPlatform('desktop'),
       isRetrying: false,
-      maargJobEnums: JSON.parse(process.env.VUE_APP_MISC_MAARG_JOB_NAMES as string) as any
+      maargJobEnums: JSON.parse(process.env.VUE_APP_MISC_MAARG_JOB_ENUMS as string) as any
     }
   },
   computed: {

src/views/Orders.vue

@@ -184,7 +184,7 @@ export default defineComponent({
       isDesktop: isPlatform('desktop'),
       enumTypeId: 'ORDER_SYS_JOB',
       initialLoadJobEnums: JSON.parse(process.env?.VUE_APP_INITIAL_JOB_ENUMS as string) as any,
-      maargJobEnums: JSON.parse(process.env.VUE_APP_ORDERS_MAARG_JOB_NAMES as string) as any,
+      maargJobEnums: JSON.parse(process.env.VUE_APP_ORDERS_MAARG_JOB_ENUMS as string) as any,
       isLoading: false
     }
   },

src/views/PreOrder.vue

@@ -262,7 +262,7 @@ export default defineComponent({
       isDesktop: isPlatform('desktop'),
       enumTypeId: 'PRE_ORD_SYS_JOB',
       preOrderBackorderCategory: {} as any,
-      maargJobEnums: JSON.parse(process.env.VUE_APP_PREORD_MAARG_JOB_NAMES as string) as any,
+      maargJobEnums: JSON.parse(process.env.VUE_APP_PREORD_MAARG_JOB_ENUMS as string) as any,
     }
   },
   methods: {