Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic mode for Cabal files (Haskell) #557

Closed
wants to merge 1 commit into from

Conversation

dgaw
Copy link
Contributor

@dgaw dgaw commented Mar 7, 2020

Closes #556

@refi64
Copy link
Contributor

refi64 commented Mar 12, 2020

Thanks for the contribution! However, basic_modes are generally "legacy" lexers (pulled from LPeg I think?). All the new ones are Howl-native bundles instead.

@dgaw
Copy link
Contributor Author

dgaw commented Mar 12, 2020

Thanks for reviewing @refi64!

If this is a matter of packaging then I can create a new bundle called "haskell" and move the haskell mode along with my cabal mode from "basic_modes" into this bundle.

What do you think?

@refi64
Copy link
Contributor

refi64 commented Mar 17, 2020

I mean you could, but they have slightly different syntaxes, even though they're both built on top of LPeg, so it would have to be more of a port. For the moment, I'd suggest just moving the Cabal one over to make things easier.

@dgaw
Copy link
Contributor Author

dgaw commented Apr 13, 2020

I use Haskell often so I don't mind spending a little time porting the Cabal mode, as well as the Haskell mode to the new syntax.

I think it would be a logical move to create a "haskell" bundle with those two modes in it since all Haskell projects use Cabal files. Also this would give us a container for future development of Haskell-related functionality.

@refi64 Thanks for reviewing my PR. It took me a while to get back to this, sorry! Do you see any problems with this?

@shalabhc
Copy link
Contributor

@dgaw, given the code is small, do you mind porting it to the 'new style' modes in its own bundle? E.g. bundles/cabal.

For a simple example you could look at bundles/haml.

@dgaw
Copy link
Contributor Author

dgaw commented Sep 8, 2020

I don't mind porting the cabal mode in its own bundle.

However, what do you think about creating a haskell bundle I mentioned earlier?

@shalabhc
Copy link
Contributor

Oh ya - a haskell bundle sounds even better.

If you do, please add an examples folder like some bundles have with a file containing haskell code. Doesn't have to work, just to see the syntax highlighting.

@dgaw
Copy link
Contributor Author

dgaw commented Sep 11, 2020

Sure. I'll add an examples folder when I get around to implementing this.

@dgaw
Copy link
Contributor Author

dgaw commented Sep 22, 2020

Superseded by #584

@dgaw dgaw closed this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A basic mode for Cabal files (Haskell)
3 participants