-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic mode for Cabal files (Haskell) #557
Conversation
Thanks for the contribution! However, basic_modes are generally "legacy" lexers (pulled from LPeg I think?). All the new ones are Howl-native bundles instead. |
Thanks for reviewing @refi64! If this is a matter of packaging then I can create a new bundle called "haskell" and move the haskell mode along with my cabal mode from "basic_modes" into this bundle. What do you think? |
I mean you could, but they have slightly different syntaxes, even though they're both built on top of LPeg, so it would have to be more of a port. For the moment, I'd suggest just moving the Cabal one over to make things easier. |
I use Haskell often so I don't mind spending a little time porting the Cabal mode, as well as the Haskell mode to the new syntax. I think it would be a logical move to create a "haskell" bundle with those two modes in it since all Haskell projects use Cabal files. Also this would give us a container for future development of Haskell-related functionality. @refi64 Thanks for reviewing my PR. It took me a while to get back to this, sorry! Do you see any problems with this? |
@dgaw, given the code is small, do you mind porting it to the 'new style' modes in its own bundle? E.g. For a simple example you could look at bundles/haml. |
I don't mind porting the However, what do you think about creating a |
Oh ya - a haskell bundle sounds even better. If you do, please add an examples folder like some bundles have with a file containing haskell code. Doesn't have to work, just to see the syntax highlighting. |
Sure. I'll add an examples folder when I get around to implementing this. |
Superseded by #584 |
Closes #556