Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_date broke commit_begin command line option #36

Open
janihur opened this issue Sep 19, 2014 · 1 comment
Open

start_date broke commit_begin command line option #36

janihur opened this issue Sep 19, 2014 · 1 comment

Comments

@janihur
Copy link

janihur commented Sep 19, 2014

I think commit 780c0fd (start_date command line option) introduced a bug that broke commit_begin command line option.

def getlogrange(defaultrange = 'HEAD', end_only = True):
    commit_range = getcommitrange(defaultrange, end_only)
    if len(conf['start_date']) > 0:
        return '--since=%s %s' % (conf['start_date'], commit_range)
    return commit_range

The way how getlogrange is implemented and called in other parts means commit_begin has no effect.
I propose the following fix:

  1. Make start_date and commit_begin command line options mutually exclusive - only one of them can be defined. Error will be raised if both options are present.
  2. Modify getxxxrange so that all combinations of start_date, commit_begin and end_only are handled correctly.
fjra added a commit to fjra/gitstats that referenced this issue May 25, 2018
@fjra fjra mentioned this issue May 25, 2018
@rdkmaster
Copy link

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants