Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more build options #757

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

adding more build options #757

wants to merge 3 commits into from

Conversation

francinelapid
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

Closes #745

Paul-Ferrell
Paul-Ferrell previously approved these changes Mar 21, 2024
copystat=utils.make_umask_filtered_copystat(umask),
symlinks=True)
source_copy = self._config.get('source_copy')
if source_copy.lower() == 'true':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the utils.py str_bool here.

Comment on lines 198 to 209
def symlinktree(source_directory, destination_directory):
for root, dirs, files in os.walk(source_directory):
for file in files:
src_path = os.path.join(root, file)
rel_path = os.path.relpath(src_path, source_directory)
dst_path = os.path.join(destination_directory, rel_path)

# Create
os.makedirs(os.path.dirname(dst_path), exist_ok=True)
os.symlink(src_path, dst_path)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started write that you should mimic how this is done in builder.py with maybe_symlink_copy, but with some of the options you need to add this way is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build options for large external builds
2 participants