Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check possible undefined behavior bugs #37

Open
nightlark opened this issue Sep 5, 2019 · 0 comments
Open

Check possible undefined behavior bugs #37

nightlark opened this issue Sep 5, 2019 · 0 comments

Comments

@nightlark
Copy link
Contributor

nightlark commented Sep 5, 2019

https://github.com/LLNL/TraceR/blob/master/tracer/p2p-events.C#L745

int64_t seq = 0; /* is there a better value to set if the if statement doesn't set it? */
  if(b->c7) {
    if(t->event_id == TRACER_RECV_COMP_EVT) {
      ns->my_pe->pendingRReqs[t->req_id] = t->myEntry.msgId.seq;`
  • Check for undefined behavior if b->c7 is false and seq doesn't get initialized correctly (0 might not be a safe default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant