544 configure meilisearch #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilisearch with one search term
olschulz
reviewed
Jun 16, 2023
Co-authored-by: Oliver Schulz <64468276+olschulz@users.noreply.github.com>
MariusDoe
requested changes
Jun 16, 2023
| @@ -34,6 +34,8 @@ | |||
| "pg": "8.6.0", | |||
| "pm2": "^5.2.0", | |||
| "sendmail": "^1.6.1", | |||
| "sharp": "^0.32.1", | |||
There was a problem hiding this comment.
I looked this up and it seems to be related to image optimization. Do we do some sort of image search or why do we need this package?
There was a problem hiding this comment.
i merged staging into my local branch and and suddenly got errors because the sharp package was missing, so installed it. I don't know where this dependency comes from
There was a problem hiding this comment.
Strange, for me it works without the package
projects/bp-gallery/src/components/views/search/helpers/getSearchResultPictureIds.ts
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/search/helpers/getSearchResultPictureIds.ts
Outdated
Show resolved
Hide resolved
MariusDoe
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config should be mostly fine now, maybe some tweaking will be necessary in the future. The helper function can be used to test the search functionality, but it needs a running meilisearch instance to work. The installation is quick and easy, see: https://www.meilisearch.com/docs/learn/getting_started/installation . So far the search is not implemented in the site. I used a console.log() in the searchview to test the results so far and left it in the pr for the reviewers convenience.