refac & feat: now there is only one item details view instead of two, also design adjusted #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navetis
requested review from
codingWhale13,
FSadrieh,
ko-redtruck,
LeoKohlenberg,
leonardhorns and
MatthisCl
Gemfile.lock
Outdated
| @@ -88,9 +88,9 @@ GEM | |||
| bcrypt (3.1.18) | |||
| bindata (2.4.14) | |||
| bindex (0.8.1) | |||
| bootsnap (1.13.0) | |||
| bootsnap (1.15.0) | |||
There was a problem hiding this comment.
Is it necessary to update all these gems? It seems to me (and I could well be wrong :P) that this risks breaking things somewhere in the project.
Are there any new gems introduced?
There was a problem hiding this comment.
I've taken the liberty of undoing the effects of the bundle update command you probably executed. This way, checks pass again.
| @@ -4,7 +4,7 @@ class Item < ApplicationRecord | |||
|
|
|||
| validates :name, presence: true | |||
| validates :max_reservation_days, numericality: { greater_than_or_equal_to: 0, less_than_or_equal_to: 365 } | |||
| validates :max_borrowing_days, numericality: { greater_than_or_equal_to: 0 } | |||
| validates :max_borrowing_days, numericality: { greater_than: 0 } | |||
There was a problem hiding this comment.
This makes sense.
To keep track of these "on-the-side" changes, it might be nice to give a summary of changed things (that are not obvious from the PR title) in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136