Increase code coverage

Author: bitwiseman

src/main/java/org/kohsuke/github/GHIssueQueryBuilder.java

@@ -104,7 +104,7 @@ public GHIssueQueryBuilder since(Instant date) {
      * @return the gh issue query builder
      */
     public GHIssueQueryBuilder since(long timestamp) {
-        return since(Instant.ofEpochMilli(timestamp));
+        return since(new Date(timestamp));
     }
 
     /**

src/main/java/org/kohsuke/github/GHMilestone.java

@@ -60,8 +60,6 @@ public GHUser getCreator() {
      */
     @WithBridgeMethods(value = Date.class, adapterMethod = "instantToDate")
     public Instant getDueOn() {
-        if (due_on == null)
-            return null;
         return GitHubClient.parseInstant(due_on);
     }
 

src/main/java/org/kohsuke/github/GHRelease.java

@@ -43,7 +43,7 @@ public GHRelease() {
     private String body;
     private boolean draft;
     private boolean prerelease;
-    private String published_at;
+    private String publishedAt;
     private String tarball_url;
     private String zipball_url;
     private String discussion_url;
@@ -102,16 +102,6 @@ public String getName() {
         return name;
     }
 
-    /**
-     * Sets name.
-     *
-     * @param name
-     *            the name
-     */
-    public void setName(String name) {
-        this.name = name;
-    }
-
     /**
      * Gets owner.
      *
@@ -135,7 +125,9 @@ public boolean isPrerelease() {
      * Gets published at.
      *
      * @return the published at
+     * @deprecated Use #getPublishedAt()
      */
+    @Deprecated
     public Date getPublished_at() {
         return Date.from(getPublishedAt());
     }
@@ -146,7 +138,7 @@ public Date getPublished_at() {
      * @return the published at
      */
     public Instant getPublishedAt() {
-        return GitHubClient.parseInstant(published_at);
+        return GitHubClient.parseInstant(publishedAt);
     }
 
     /**

src/test/java/org/kohsuke/github/GHMilestoneTest.java

@@ -75,6 +75,7 @@ public void testUpdateMilestone() throws Exception {
         // The time is truncated when sent to the server, but still part of the returned value
         // 07:00 midnight PDT
         assertThat(milestone.getDueOn(), equalTo(OUTPUT_DUE_DATE));
+        assertThat(milestone.getClosedAt(), nullValue());
         assertThat(milestone.getHtmlUrl().toString(), containsString("/hub4j-test-org/github-api/milestone/"));
         assertThat(milestone.getUrl().toString(), containsString("/repos/hub4j-test-org/github-api/milestones/"));
         assertThat(milestone.getClosedIssues(), equalTo(0));

src/test/java/org/kohsuke/github/GHReleaseTest.java

@@ -36,7 +36,12 @@ public void testCreateSimpleRelease() throws Exception {
             assertThat(releaseCheck, notNullValue());
             assertThat(releaseCheck.getTagName(), is(tagName));
             assertThat(releaseCheck.isPrerelease(), is(false));
+            assertThat(releaseCheck.isDraft(), is(false));
+            assertThat(releaseCheck.getAssetsUrl(), endsWith("/assets"));
             assertThat(releaseCheck.getDiscussionUrl(), notNullValue());
+            assertThat(releaseCheck.getCreatedAt(), equalTo(GitHubClient.parseInstant("2021-06-02T21:59:14Z")));
+            assertThat(releaseCheck.getPublishedAt(), equalTo(GitHubClient.parseInstant("2021-06-11T06:56:52Z")));
+
         } finally {
             release.delete();
             assertThat(repo.getRelease(release.getId()), nullValue());

src/test/java/org/kohsuke/github/GitHubStaticTest.java

@@ -12,6 +12,7 @@
 import java.time.format.DateTimeFormatter;
 import java.time.format.DateTimeParseException;
 import java.time.temporal.ChronoUnit;
+import java.util.Date;
 import java.util.Locale;
 
 import static org.hamcrest.CoreMatchers.*;
@@ -136,6 +137,12 @@ public void timeRoundTrip() {
         } catch (DateTimeParseException e) {
             assertThat(e.getMessage(), equalTo("Text '" + instantBadFormat + "' could not be parsed at index 0"));
         }
+
+        final GitHubBridgeAdapterObject bridge = new GitHubBridgeAdapterObject() {
+        };
+        assertThat(bridge.instantToDate(null, null), nullValue());
+        assertThat(bridge.instantToDate(Instant.ofEpochMilli(stableInstantEpochMilli), null),
+                equalTo(Date.from(instantNow)));
     }
 
     /**

src/test/java/org/kohsuke/github/GitHubTest.java

@@ -336,6 +336,10 @@ public void getMyMarketplacePurchases() throws IOException {
             assertThat(userPurchase.isOnFreeTrial(), is(false));
             assertThat(userPurchase.getFreeTrialEndsOn(), nullValue());
             assertThat(userPurchase.getBillingCycle(), equalTo("monthly"));
+            assertThat(userPurchase.getNextBillingDate(),
+                    equalTo(GitHubClient.parseInstant("2020-01-01T00:00:00.000+13:00")));
+            assertThat(userPurchase.getUpdatedAt(),
+                    equalTo(GitHubClient.parseInstant("2019-12-02T00:00:00.000+13:00")));
 
             GHMarketplacePlan plan = userPurchase.getPlan();
             // GHMarketplacePlan - Non-nullable fields