-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Inference Docs #274
Comments
I'm open to feedback and suggestions! I created a draft PR to help you visualize what I'm going for. |
thanks @ArsalaBangash , this a great idea! thanks for helping improving the docs. I'm happy to review the changes. |
Good stuff, @ArsalaBangash! Few comments:
I think we should keep task types (CV, NLP, etc.) that previously where comments in the big code block, just make them to be headers not comments. It looks more structured and easier to navigate with them :-)
It might be confusing that javascript examples provided there are nodejs and plain fetch(), would be nice to have huggingface.js examples as well :-) But as I understand these docs are compiled from private repo https://github.com/huggingface/api-inference not sure if HF allows contributions to that repo. Maybe |
Oh yes we should definitely use hf.js there. I'm not sure it's possible to use in a separate repo, since docs are generated from a tests file (doc snippets are actually run as tests as well). I will check in with the team regarding updating the JS examples to HF.js |
@vvmnnnkv I agree with your suggestion of grouping by task type. @coyotte508 My 2 cents on converting the api-inference js examples to hf.js: If we have customers who prefer calling the inference API without hf.js, then having those examples is still worth it. |
yes the consensus regarding api-inference is to improve the examples (remove |
I committed changes to #275. Live Preview Before I mark the PR as ready for review, I'd like to clarify:
|
Docs are live so I'm closing this issue. |
Context
I've been building tutorials and creating demos for the inference library, and I find myself going back and forth between the JS Library Inference Docs and the Detailed Params documentation
Suggestions
The text was updated successfully, but these errors were encountered: