Skip to content

Update slack_sender.py #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shauryauppal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update slack_sender.py #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions knockknock/slack_sender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

DATE_FORMAT = "%Y-%m-%d %H:%M:%S"

def slack_sender(webhook_url: str, channel: str, user_mentions: List[str] = []):
def slack_sender(webhook_url: str, channel: str, user_mentions: List[str] = [], username: str, icon_emoji: str):
"""
Slack sender wrapper: execute func, send a Slack notification with the end status
(sucessfully finished or crashed) at the end. Also send a Slack notification before
Expand All @@ -26,7 +26,7 @@ def slack_sender(webhook_url: str, channel: str, user_mentions: List[str] = []):
"""

dump = {
"username": "Knock Knock",
"username": username,
"channel": channel,
"icon_emoji": ":clapper:",
}
Expand Down