C and C++ bindings to Tokenizers #1888
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
very open to this! let's make sure we have a big compat with expectations in terms of the funcs we bind
| @@ -0,0 +1,133 @@ | |||
| use std::ffi::{CStr, CString}; | |||
| } | ||
|
|
||
| #[no_mangle] | ||
| pub extern "C" fn tokenizers_encode( |
Collaborator
There was a problem hiding this comment.
think we need decode, batch encode batch encode fast etc and asyc? I don't know how best to define these all but basically the same surface as python!
Author
There was a problem hiding this comment.
Thanks for the quick review! Happy to know you're interested/open to this effort.
I will get back after surfacing more functionality to C++.
CPP bindings coverage improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in bindings for two more languages!
bindings/cppbindings/cC is an intermediate step to bind C++ and Rust: i.e., C++ <--> C <--> Rust.
--