Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set non_blocking=True when move data from cpu to gpu #36408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

set non_blocking=True when move data from cpu to gpu #36408

wants to merge 1 commit into from
+1 −1

Conversation

Hukongtao
Copy link

What does this PR do?

Fixes 36384

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Hukongtao Hukongtao mentioned this pull request Feb 26, 2025
Open
4 tasks
@Rocketknight1
Copy link
Member

cc @muellerzr @SunMarc

@SunMarc
Copy link
Member

SunMarc commented Feb 26, 2025

Could you try to set non_blocking using accelerator_config in TrainingArguments ? This should be the dataloader job to put the data on the right device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set non_blocking=True When moving data from the CPU to the GPU
3 participants
@Hukongtao @Rocketknight1 @SunMarc