Remove _dynamic_tied_weights_keys #42069
Open
+4,799
−3,310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sformers into refactor-weight-loading
…tor-weight-loading
…sformers into refactor-weight-loading
…sformers into refactor-weight-loading
…sformers into refactor-weight-loading
This reverts commit 3fea865.
* No need to check _dynamic_tied_weights_keys and no need for recursion * Updated an error message that mentioned _dynamic_tied_weights_keys * Removed a test that involved _dynamic_tied_weights_keys The attribute is still referenced in the custom tie_weights method of musicgen and musicgen_melody, but my understanding is that the custom method will be removed anyway, so I left it there.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
force-pushed
the
refactor-weight-loading
branch
from
28b620d to
f692f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_dynamic_tied_weights_keysand no need for recursion in_get_tied_weight_keys_dynamic_tied_weights_keys_dynamic_tied_weights_keysThe attribute is still referenced in the custom
tie_weightsmethod ofmusicgenandmusicgen_melody, but my understanding is that the custom method will be removed anyway, so I left it there.