Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Mark MR as approved but do not accept #85

Closed
sergiopvilar opened this issue Jun 29, 2016 · 2 comments
Closed

Mark MR as approved but do not accept #85

sergiopvilar opened this issue Jun 29, 2016 · 2 comments

Comments

@sergiopvilar
Copy link
Contributor

With the feature introduced in #66 will be great if we had the ability to approve a MR when there's more than one reviewer but not properly accept it. The purpose of this feature is to give an approval to the people that will merge the MR. We can also introduce an option that the MR only can be merged when all reviewers give the approval.

@hugopl
Copy link
Owner

hugopl commented Apr 24, 2018

I think it's better to implement this as a specific way to say +1 to the MR.

hugopl added a commit that referenced this issue Aug 24, 2019
Thsi fix the issue #85.
@hugopl
Copy link
Owner

hugopl commented Aug 24, 2019

implemented :-)

@hugopl hugopl closed this as completed Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants