Update links for Python version changes #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Nov 28, 2025
| "reasons": """ | ||
| <li><a href="https://github.com/jugmac00/python-version-cheat-sheet#python-310">use <code>match</code> statement and write union types as <code>X | Y</code></a></li> | ||
| <li><a href="https://docs.python.org/3/whatsnew/3.9.html">And more!</a></li> | ||
| <li><a href="https://docs.python.org/3/whatsnew/3.10.html">And more!</a></li> |
Owner
There was a problem hiding this comment.
Good find!
Rather than just fixing, as I'll probably make the same mistake in the future, can we futureproof this via templating?
For example for all of these:
Suggested change
| <li><a href="https://docs.python.org/3/whatsnew/3.10.html">And more!</a></li> | |
| <li><a href="https://docs.python.org/3/whatsnew/{{next_version}}.html">And more!</a></li> |
And then check it's replaced somewhere below.
Contributor
Author
There was a problem hiding this comment.
Rather than just fixing, as I'll probably make the same mistake in the future, can we futureproof this via templating?
Indeed that would be better but I only have time (at least for now) to contribute this very small fix rather than the proposed future proof templating option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"what's new" link were pointing to the dropped version for 3.9 & 3.10