Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs import error: No type set for period #43

Open
roger-mahler opened this issue Mar 19, 2020 · 5 comments
Open

Bugs import error: No type set for period #43

roger-mahler opened this issue Mar 19, 2020 · 5 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@roger-mahler
Copy link
Collaborator

These 24 errors are caused by records in "TPeriods" having "YearsType" equal to NULL.

The latest BugsCEP database on SEADSERV bugsdata_20200219 gives the erroneous(?) records:

select *
from "TPeriods"
where "YearsType" is null

Currently, the Bugs import tries to assign an age if and only if"YearsType" is "Calendar", "C14" or "Radiometric" as indicated by the following code snippet;

        if(period.getYearsType() != null ){
            switch (period.getYearsType()){
                case "Calendar":
                case "calendar":
                case "Calender":
                case "calender": return new CalendarAgeUpdater(original, period);
                case "C14":
                case "c14":
                case "Radiometric":
                case "radiometric": return new C14AgeUpdater(original, period);
            }
        }
        return new UndeterminedAgeUpdater(original, period);
@roger-mahler
Copy link
Collaborator Author

roger-mahler commented Mar 19, 2020

Affected BugsCEP PeriodCodes:

PeriodCODE Period Name
ERom Early Roman
InterG Interglacial
MIS-02 Oxygen Isotope Stage 2
MIS-03 Oxygen Isotope Stage 3
MIS-04 Oxygen Isotope Stage 4
MIS-05 Oxygen Isotope Stage 5
MIS-05b Oxygen Isotope Stage 5b
MIS-05c Oxygen Isotope Stage 5c
MIS-05d Oxygen Isotope Stage 5d
MIS-06 Oxygen Isotope Stage 6
MIS-08 Oxygen Isotope Stage 8
MIS-10 Oxygen Isotope Stage 10
MIS-14 Oxygen Isotope Stage 14
MIS-14/15 Oxygen Isotope Stage 14/15
MIS-15 Oxygen Isotope Stage 15
MIS-16 Oxygen Isotope Stage 16
MIS-17 Oxygen Isotope Stage 17
MIS-18 Oxygen Isotope Stage 18
MIS-19 Oxygen Isotope Stage 19
MIS-20 Oxygen Isotope Stage 20
MIS-21 Oxygen Isotope Stage 21
MIS-22 Oxygen Isotope Stage 22
MIS-23 Oxygen Isotope Stage 23
Mking Middle Kingdom

@visead
Copy link
Contributor

visead commented Mar 19, 2020 via email

@roger-mahler
Copy link
Collaborator Author

Same as #33.

@visead
Copy link
Contributor

visead commented Mar 20, 2020

Set type as follows, where 'underfined' is a new type

PeriodCODE | Period Name | type
-- | --
ERom | Early Roman | calendar
InterG | Interglacial | undefined
MIS-02 | Oxygen Isotope Stage 2 | undefined
MIS-03 | Oxygen Isotope Stage 3 | undefined
MIS-04 | Oxygen Isotope Stage 4 | undefined
MIS-05 | Oxygen Isotope Stage 5 | undefined
MIS-05b | Oxygen Isotope Stage 5b | undefined
MIS-05c | Oxygen Isotope Stage 5c | undefined
MIS-05d | Oxygen Isotope Stage 5d | undefined
MIS-06 | Oxygen Isotope Stage 6 | undefined
MIS-08 | Oxygen Isotope Stage 8 | undefined
MIS-10 | Oxygen Isotope Stage 10 | undefined
MIS-14 | Oxygen Isotope Stage 14 | undefined
MIS-14/15 | Oxygen Isotope Stage 14/15 | undefined
MIS-15 | Oxygen Isotope Stage 15 | undefined
MIS-16 | Oxygen Isotope Stage 16 | undefined
MIS-17 | Oxygen Isotope Stage 17 | undefined
MIS-18 | Oxygen Isotope Stage 18 | undefined
MIS-19 | Oxygen Isotope Stage 19 | undefined
MIS-20 | Oxygen Isotope Stage 20 | undefined
MIS-21 | Oxygen Isotope Stage 21 | undefined
MIS-22 | Oxygen Isotope Stage 22 | undefined
MIS-23 | Oxygen Isotope Stage 23 | undefined
Mking | Middle Kingdom | calendar

@visead
Copy link
Contributor

visead commented Jun 11, 2020

I have updated table TPeriods in BugsCEP so that all periods have a Years type which is one of four alternatives: C14, Calendar, undefined, Radiometric.
For simplicity, all Radiometric Years types have been changed to Calendar, as the nature of the evidence varies.

This will be reflected in the June BugsCEP udpate.

@roger-mahler roger-mahler removed this from the SEAD @2020.04 release milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants