Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy - Creates instance using different docker image #44

Closed
rapcmia opened this issue Jun 25, 2024 · 2 comments
Closed

Deploy - Creates instance using different docker image #44

rapcmia opened this issue Jun 25, 2024 · 2 comments

Comments

@rapcmia
Copy link
Contributor

rapcmia commented Jun 25, 2024

When testing PR18 then launch the bot with controller but without selected available image it uses dardonacci/hummingbot:latest instead of hummingbot/hummingbot:latest

image
image

Recording here: https://www.loom.com/share/4bdd19ce15724943845641386d7d5134

Steps to reproduce:

  1. Setup deploy on source ( dashboard + backend-api + hummingbot-broker )
  2. On dashboard page, create config then deploy without selecting any images
  3. Go to terminal and run docker ps or docker images to check the container and image used
@rapcmia rapcmia assigned cardosofede and unassigned cardosofede Jun 25, 2024
@cardosofede
Copy link
Contributor

good catch @rapcmia
here is the fix: hummingbot/dashboard#152
@david-hummingbot build the new dashboard image from this PR if works

@rapcmia
Copy link
Contributor Author

rapcmia commented Jun 25, 2024

Fix merged to master branch hummingbot/dashboard#152

@rapcmia rapcmia closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cardosofede @rapcmia