Skip to content

read_save: checking file extension is different #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huni1023 opened this issue Mar 7, 2024 · 1 comment
Open

read_save: checking file extension is different #2

huni1023 opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@huni1023
Copy link
Owner

huni1023 commented Mar 7, 2024

in read_save.py, there are bunch of method checking file extension.

while in the method save_pkl line 16 checking extension with directly slicing string, the method read_yaml line 26 checking extension with os.path.splitext.

for consistency, using unified method to checking file extension is required.

** in pandize_folder, the extension means string without dot. but in save_pkl the extension contains dot.

@huni1023 huni1023 added the enhancement New feature or request label Mar 7, 2024
@huni1023
Copy link
Owner Author

unite extension checking method to endswith: 82ec5bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant