From af9a9228b95633f9d7e1f997376273ba6d648b7e Mon Sep 17 00:00:00 2001 From: Hunter Johnston <64506580+huntabyte@users.noreply.github.com> Date: Sun, 27 Aug 2023 12:14:08 -0400 Subject: [PATCH] upgrade melt for select portal bug fix (#93) --- .changeset/cool-dryers-glow.md | 5 +++++ package.json | 2 +- pnpm-lock.yaml | 14 +++++++------- src/components/demos/menubar-demo.svelte | 5 ++++- src/components/ui/menubar/menubar-item.svelte | 1 + 5 files changed, 18 insertions(+), 9 deletions(-) create mode 100644 .changeset/cool-dryers-glow.md diff --git a/.changeset/cool-dryers-glow.md b/.changeset/cool-dryers-glow.md new file mode 100644 index 000000000..bfb71ca12 --- /dev/null +++ b/.changeset/cool-dryers-glow.md @@ -0,0 +1,5 @@ +--- +"bits-ui": patch +--- + +- Upgrade Melt UI to resolve `Select` portal bug diff --git a/package.json b/package.json index 08f1eb4d9..5003b58be 100644 --- a/package.json +++ b/package.json @@ -84,7 +84,7 @@ "types": "./dist/index.d.ts", "type": "module", "dependencies": { - "@melt-ui/svelte": "0.39.1", + "@melt-ui/svelte": "0.39.3", "nanoid": "^4.0.2" }, "peerDependencies": { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index d44376f05..e06d614d8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -6,8 +6,8 @@ settings: dependencies: '@melt-ui/svelte': - specifier: 0.39.1 - version: 0.39.1(svelte@4.1.2) + specifier: 0.39.3 + version: 0.39.3(svelte@4.1.2) nanoid: specifier: ^4.0.2 version: 4.0.2 @@ -21,7 +21,7 @@ devDependencies: version: 0.16.5(svelte@4.1.2) '@melt-ui/pp': specifier: ^0.1.2 - version: 0.1.2(@melt-ui/svelte@0.39.1)(svelte@4.1.2) + version: 0.1.2(@melt-ui/svelte@0.39.3)(svelte@4.1.2) '@playwright/test': specifier: ^1.28.1 version: 1.36.2 @@ -996,19 +996,19 @@ packages: - supports-color dev: true - /@melt-ui/pp@0.1.2(@melt-ui/svelte@0.39.1)(svelte@4.1.2): + /@melt-ui/pp@0.1.2(@melt-ui/svelte@0.39.3)(svelte@4.1.2): resolution: {integrity: sha512-GZeqp7UWLNZUC2dJpREnZrWMR88vy27WO7C3cIBz4KW3/CFD19FjNkd3VbSRfcRryrMkdnEs9nu2VUa8/0u58w==} engines: {pnpm: '>=8.6.3'} peerDependencies: '@melt-ui/svelte': '>= 0.29.0' svelte: ^3.55.0 || ^4.0.0 dependencies: - '@melt-ui/svelte': 0.39.1(svelte@4.1.2) + '@melt-ui/svelte': 0.39.3(svelte@4.1.2) svelte: 4.1.2 dev: true - /@melt-ui/svelte@0.39.1(svelte@4.1.2): - resolution: {integrity: sha512-jrMmhm201fWP1GlStanj6U7ib1JMjm0hScCQpe/B2L7sDUDZtShyONtQQzCrYssAz986tF4D3Ty8d9oZNBVmtg==} + /@melt-ui/svelte@0.39.3(svelte@4.1.2): + resolution: {integrity: sha512-PJKo4CUDfr4bnONOuz9hLdBCo0Fz4XT8oFEdFbFCFUTqbXfEeVMN60ZHmJrolPob5mpkbp1BWg+Uy+eoEDbxig==} peerDependencies: svelte: '>=3 <5' dependencies: diff --git a/src/components/demos/menubar-demo.svelte b/src/components/demos/menubar-demo.svelte index 3a97dbc0d..e3b23f73c 100644 --- a/src/components/demos/menubar-demo.svelte +++ b/src/components/demos/menubar-demo.svelte @@ -11,7 +11,10 @@ File - New Tab + console.log("click")} + on:pointerdown={() => console.log("pointerdown")}>New Tab New Window New Incognito Window diff --git a/src/components/ui/menubar/menubar-item.svelte b/src/components/ui/menubar/menubar-item.svelte index 8f92be5dd..dfd5a2c5c 100644 --- a/src/components/ui/menubar/menubar-item.svelte +++ b/src/components/ui/menubar/menubar-item.svelte @@ -19,6 +19,7 @@ className )} {...$$restProps} + on:click on:focusin on:focusout on:keydown