From 76b51cf3f5a8ba5f831d41ab69981bcbe93bf4dd Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:21:16 -0400
Subject: [PATCH 1/6] doesnt seem necessary here

---
 .../src/lib/bits/accordion/components/accordion-header.svelte | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/packages/bits-ui/src/lib/bits/accordion/components/accordion-header.svelte b/packages/bits-ui/src/lib/bits/accordion/components/accordion-header.svelte
index 0ab234563..95f9d943c 100644
--- a/packages/bits-ui/src/lib/bits/accordion/components/accordion-header.svelte
+++ b/packages/bits-ui/src/lib/bits/accordion/components/accordion-header.svelte
@@ -1,12 +1,8 @@
 <script lang="ts">
-	import { ACCORDION_ITEM } from "../state.svelte.js";
 	import type { AccordionHeaderProps } from "../types.js";
-	import { verifyContextDeps } from "$lib/internal/index.js";
 
 	let { asChild, level = 2, children, child, ...restProps }: AccordionHeaderProps = $props();
 
-	verifyContextDeps(ACCORDION_ITEM);
-
 	const mergedProps = $derived({
 		...restProps,
 		role: "heading",

From 36e68b0ef59f2a9e3485275460ef8b05acb4b7e4 Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:21:52 -0400
Subject: [PATCH 2/6] fix union

---
 packages/bits-ui/src/lib/bits/accordion/types.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/bits-ui/src/lib/bits/accordion/types.ts b/packages/bits-ui/src/lib/bits/accordion/types.ts
index 998a3cd54..60e40fa54 100644
--- a/packages/bits-ui/src/lib/bits/accordion/types.ts
+++ b/packages/bits-ui/src/lib/bits/accordion/types.ts
@@ -23,9 +23,9 @@ interface MultipleAccordionProps extends BaseAccordionProps {
 	value?: string[];
 }
 
-export type AccordionRootPropsWithoutHTML = WithAsChild<
-	SingleAccordionProps | MultipleAccordionProps
->;
+export type AccordionRootPropsWithoutHTML =
+	| WithAsChild<SingleAccordionProps>
+	| WithAsChild<MultipleAccordionProps>;
 
 export type AccordionRootProps = AccordionRootPropsWithoutHTML & PrimitiveDivAttributes;
 

From 88dd1055b5f795d330772be55ff8c3d41ef5f2a1 Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:21:58 -0400
Subject: [PATCH 3/6] todo

---
 packages/bits-ui/src/lib/internal/context.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/bits-ui/src/lib/internal/context.ts b/packages/bits-ui/src/lib/internal/context.ts
index 558e69394..2498233b7 100644
--- a/packages/bits-ui/src/lib/internal/context.ts
+++ b/packages/bits-ui/src/lib/internal/context.ts
@@ -1,5 +1,6 @@
 import { getAllContexts } from "svelte";
 
+// TODO: should this be a DEV only feature?
 export function verifyContextDeps(...deps: symbol[]) {
 	const ctx = getAllContexts();
 	const missing = deps.filter((dep) => !ctx.has(dep));

From 2b6cc31e32e9df9ac115f5cf6666c3e5f1d7551f Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:22:07 -0400
Subject: [PATCH 4/6] simplify defaults

---
 .../src/lib/bits/accordion/state.svelte.ts    | 112 ++++++------------
 1 file changed, 38 insertions(+), 74 deletions(-)

diff --git a/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts b/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
index 9e0d7feed..7ee81458f 100644
--- a/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
+++ b/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
@@ -13,31 +13,21 @@ import {
 /**
  * BASE
  */
-export type AccordionBaseStateProps = {
+interface AccordionBaseStateProps {
 	el?: HTMLElement | null;
 	disabled?: boolean;
 	forceVisible?: boolean;
-};
-
-const defaultAccordionRootBaseProps = {
-	el: null,
-	disabled: false,
-	forceVisible: false,
-} satisfies Required<AccordionBaseStateProps>;
+}
 
 class AccordionBaseState {
-	el: HTMLElement | null | undefined = $state();
+	el: HTMLElement | null | undefined = $state(null);
 	disabled: boolean = $state(false);
 	forceVisible: boolean = $state(false);
 
-	constructor(props: AccordionBaseStateProps = {}) {
-		const mergedProps = {
-			...defaultAccordionRootBaseProps,
-			...removeUndefined(props),
-		} satisfies AccordionBaseStateProps;
-		this.el = mergedProps.el;
-		this.disabled = mergedProps.disabled;
-		this.forceVisible = mergedProps.forceVisible;
+	constructor(props: AccordionBaseStateProps) {
+		this.el = props.el ?? this.el;
+		this.disabled = props.disabled ?? this.disabled;
+		this.forceVisible = props.forceVisible ?? this.forceVisible;
 	}
 }
 
@@ -45,30 +35,21 @@ class AccordionBaseState {
  * SINGLE
  */
 
-export type AccordionSingleStateProps = {
+interface AccordionSingleStateProps extends AccordionBaseStateProps {
 	value?: string;
 	onValueChange?: OnChangeFn<string>;
-} & AccordionBaseStateProps;
-
-const defaultAccordionRootSingleProps: Required<AccordionSingleStateProps> = {
-	value: "",
-	onValueChange: () => {},
-	...defaultAccordionRootBaseProps,
-} satisfies Required<AccordionSingleStateProps>;
+}
 
 export class AccordionSingleState extends AccordionBaseState {
 	value: string = $state("");
-	onValueChange: OnChangeFn<string>;
+	onValueChange: OnChangeFn<string> = () => {};
 	isMulti = false as const;
 
-	constructor(props: AccordionSingleStateProps = {}) {
-		const mergedProps = {
-			...defaultAccordionRootSingleProps,
-			...removeUndefined(props),
-		} satisfies AccordionSingleStateProps;
-		super(mergedProps);
-		this.value = mergedProps.value;
-		this.onValueChange = mergedProps.onValueChange;
+	constructor(props: AccordionSingleStateProps) {
+		super(props);
+
+		this.value = props.value ?? this.value;
+		this.onValueChange = props.onValueChange ?? this.onValueChange;
 
 		$effect.pre(() => {
 			this.onValueChange?.(this.value);
@@ -79,31 +60,21 @@ export class AccordionSingleState extends AccordionBaseState {
 /**
  * MULTIPLE
  */
-export type AccordionMultiStateProps = {
+interface AccordionMultiStateProps extends AccordionBaseStateProps {
 	value?: string[];
 	onValueChange?: OnChangeFn<string[]>;
-} & AccordionBaseStateProps;
-
-const defaultAccordionRootMultiProps = {
-	value: [],
-	onValueChange: () => {},
-	...defaultAccordionRootBaseProps,
-} satisfies Required<AccordionMultiStateProps>;
+}
 
 export class AccordionMultiState extends AccordionBaseState {
 	value: string[] = $state([]);
-	onValueChange?: (value: string[]) => void;
+	onValueChange: OnChangeFn<string[]> = () => {};
 	isMulti = true as const;
 
-	constructor(props: AccordionMultiStateProps = {}) {
-		const mergedProps = {
-			...defaultAccordionRootMultiProps,
-			...removeUndefined(props),
-		} satisfies AccordionMultiStateProps;
-		super(mergedProps);
+	constructor(props: AccordionMultiStateProps) {
+		super(props);
 
-		this.value.push(...mergedProps.value);
-		this.onValueChange = mergedProps.onValueChange;
+		this.value = props.value ?? this.value;
+		this.onValueChange = props.onValueChange ?? this.onValueChange;
 
 		$effect.pre(() => {
 			this.onValueChange?.(this.value);
@@ -276,7 +247,7 @@ class AccordionTriggerState {
  */
 
 class AccordionContentState {
-	item: AccordionItemState = undefined as unknown as AccordionItemState;
+	item: AccordionItemState = $state() as AccordionItemState;
 	attrs: Record<string, unknown> = $derived({
 		"data-state": openClosedAttrs(this.item.isSelected),
 		"data-disabled": dataDisabledAttrs(this.item.root.disabled || this.item.disabled),
@@ -297,56 +268,49 @@ class AccordionContentState {
  * CONTEXT METHODS
  */
 
-export const ACCORDION_ROOT = Symbol("Accordion.Root");
-export const ACCORDION_ITEM = Symbol("Accordion.Item");
+export const ACCORDION_ROOT_KEY = Symbol("Accordion.Root");
+export const ACCORDION_ITEM_KEY = Symbol("Accordion.Item");
 
 type AccordionState = AccordionSingleState | AccordionMultiState;
 
-type SingleInitAccordionProps = {
-	type: "single";
-	// eslint-disable-next-line ts/no-explicit-any
-	value?: any;
+type InitAccordionProps = {
+	type: "single" | "multiple";
+	value?: string | string[];
 };
 
-type MultiInitAccordionProps = {
-	type: "multiple";
-	// eslint-disable-next-line ts/no-explicit-any
-	value?: any;
-};
-
-type InitAccordionProps = SingleInitAccordionProps | MultiInitAccordionProps;
-
 export function setAccordionRootState(props: InitAccordionProps) {
 	const rootState =
-		props.type === "single" ? new AccordionSingleState(props) : new AccordionMultiState(props);
-	setContext(ACCORDION_ROOT, rootState);
+		props.type === "single"
+			? new AccordionSingleState({ value: props.value as string })
+			: new AccordionMultiState({ value: props.value as string[] });
+	setContext(ACCORDION_ROOT_KEY, rootState);
 	return rootState;
 }
 
 export function getAccordionRootState(): AccordionState {
-	return getContext(ACCORDION_ROOT);
+	return getContext(ACCORDION_ROOT_KEY);
 }
 
 export function setAccordionItemState(props: Omit<AccordionItemStateProps, "rootState">) {
-	verifyContextDeps(ACCORDION_ROOT);
+	verifyContextDeps(ACCORDION_ROOT_KEY);
 	const rootState = getAccordionRootState();
 	const itemState = new AccordionItemState({ ...props, rootState });
-	setContext(ACCORDION_ITEM, itemState);
+	setContext(ACCORDION_ITEM_KEY, itemState);
 	return itemState;
 }
 
 export function getAccordionItemState(): AccordionItemState {
-	return getContext(ACCORDION_ITEM);
+	return getContext(ACCORDION_ITEM_KEY);
 }
 
 export function getAccordionTriggerState(props: AccordionTriggerStateProps): AccordionTriggerState {
-	verifyContextDeps(ACCORDION_ITEM);
+	verifyContextDeps(ACCORDION_ITEM_KEY);
 	const itemState = getAccordionItemState();
 	return itemState.createTrigger(props);
 }
 
 export function getAccordionContentState(): AccordionContentState {
-	verifyContextDeps(ACCORDION_ITEM);
+	verifyContextDeps(ACCORDION_ITEM_KEY);
 	const itemState = getAccordionItemState();
 	return itemState.createContent();
 }

From 2f83a89bafb9d7c347d95e62773594b931b04ef0 Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:32:26 -0400
Subject: [PATCH 5/6] is now dev time only

---
 packages/bits-ui/package.json                |  1 +
 packages/bits-ui/src/lib/internal/context.ts | 12 +++++++-----
 pnpm-lock.yaml                               |  3 +++
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/packages/bits-ui/package.json b/packages/bits-ui/package.json
index 4c19e0c9a..3d5c709b5 100644
--- a/packages/bits-ui/package.json
+++ b/packages/bits-ui/package.json
@@ -55,6 +55,7 @@
 	"dependencies": {
 		"@internationalized/date": "^3.5.1",
 		"@melt-ui/svelte": "0.76.2",
+		"esm-env": "^1.0.0",
 		"nanoid": "^5.0.5"
 	},
 	"peerDependencies": {
diff --git a/packages/bits-ui/src/lib/internal/context.ts b/packages/bits-ui/src/lib/internal/context.ts
index 2498233b7..7e7421e36 100644
--- a/packages/bits-ui/src/lib/internal/context.ts
+++ b/packages/bits-ui/src/lib/internal/context.ts
@@ -1,10 +1,12 @@
 import { getAllContexts } from "svelte";
+import { DEV } from "esm-env";
 
-// TODO: should this be a DEV only feature?
 export function verifyContextDeps(...deps: symbol[]) {
-	const ctx = getAllContexts();
-	const missing = deps.filter((dep) => !ctx.has(dep));
-	if (missing.length > 0) {
-		throw new Error(`Missing context dependencies: ${missing.join(", ")}`);
+	if (DEV) {
+		const ctx = getAllContexts();
+		const missing = deps.filter((dep) => !ctx.has(dep));
+		if (missing.length > 0) {
+			throw new Error(`Missing context dependencies: ${missing.join(", ")}`);
+		}
 	}
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 30f922bd9..1d7a8bdb4 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -53,6 +53,9 @@ importers:
       '@melt-ui/svelte':
         specifier: 0.76.2
         version: 0.76.2(svelte@5.0.0-next.100)
+      esm-env:
+        specifier: ^1.0.0
+        version: 1.0.0
       nanoid:
         specifier: ^5.0.5
         version: 5.0.6

From fb2cbc5f31f3d43ba33c866f4e73141764bb82e9 Mon Sep 17 00:00:00 2001
From: AdrianGonz97 <31664583+AdrianGonz97@users.noreply.github.com>
Date: Thu, 11 Apr 2024 20:32:51 -0400
Subject: [PATCH 6/6] dont need that

---
 packages/bits-ui/src/lib/bits/accordion/state.svelte.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts b/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
index 7ee81458f..07b60a239 100644
--- a/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
+++ b/packages/bits-ui/src/lib/bits/accordion/state.svelte.ts
@@ -6,7 +6,6 @@ import {
 	dataDisabledAttrs,
 	kbd,
 	openClosedAttrs,
-	removeUndefined,
 	verifyContextDeps,
 } from "$lib/internal/index.js";