Add target attribute to menu items

[DarthGigi]

Describe the feature in detail (code, mocks, or screenshots encouraged)

TypeScript gives the following error if you try to add a target attribute to a DropdownMenu.Item component if it's a link (adding the href attribute):
Type '{ target: string; href: string; }' is not assignable to type '$$Props'. Object literal may only specify known properties, and '"target"' does not exist in type '$$Props'. ts(2322)

An a element should have support for the target attribute

What type of pull request would this be?

Enhancement

Provide relevant links or additional information.

No response

[leonardsimonse]

I can submit a PR for this, but I guess https://github.com/huntabyte/bits-ui would be the right place for it, right @huntabyte?

[huntabyte]

Hey @leonardsimonse, it would be in bits-ui, however, I'm currently in the process of a big internal refactor that I should be merging into main soonish that would likely cause some annoying conflicts if done before that PR.

During this refactor I did notice that we're typing the Menu items incorrectly when converting to links right now. They should be similar to how we handle the Button, where if an href is passed, it gets HTMLAnchorAttributes, otherwise HTMLDivAttributes. I'll transfer this issue over there as a reminder!

[leonardsimonse]

Getting the types in line with an anchor element would be the proper solution indeed @huntabyte. Let's wait for your merge.

[huntabyte]

Okay, the big PR has been merged so we can revisit this! I think ideally we do something similar to how we're handling it with the Button: https://github.com/huntabyte/bits-ui/blob/main/src/lib/bits/button/types.ts

Except the dropdown menu items aren't buttons, rather <div /> elements! If someone wants to tackle this, let me know and I'll assign it to ya, otherwise I'll get to it when I can!

[leonardsimonse]

I'd love to help out here. If you assign it me, I'll look at it in a couple of hours.

[leonardsimonse]

I think you already solved this @huntabyte at a2d2453#diff-2174b491375649b1e4b5ec28c468c52721fd9f5af9efd38aacb1db724bd63318R35 👊

[huntabyte]

Wow I guess I did! My apologies 😅 lots of changes in that one! Thanks for taking a look anyways!

Closed by #184