Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox example in documentation shows wrong results #1041

Closed
Flo0807 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1042
Closed

Combobox example in documentation shows wrong results #1041

Flo0807 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1042
Labels
type: documentation A change or addition to the documentation

Comments

@Flo0807
Copy link

Flo0807 commented Apr 22, 2024

Change Type

Correction

Proposed Changes

The Form Combobox Example in the documentation (the last example on the page) shows languages to choose from. Each language has a value and a label. The label is displayed to the user in the list and the value is used internally when selecting and submitting languages.

The problem is that the value is used to determine search results. Since the values and labels are entirely different (e.g., {label: "German", value: "de" }), this results in displaying wrong results. For example, if I type "de" into the search bar, the result will be "German".

From a user perspective, this doesn't make sense because I want to search the languages by label, since that's the property I see in the list.

Showcase video below:

showcase.mov
@Flo0807 Flo0807 added the type: documentation A change or addition to the documentation label Apr 22, 2024
@shyakadavis
Copy link
Contributor

Hi;

If this is not intentional (I'm pretty sure it's not), I'll go ahead and start working on a fix. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants