Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve UX for Component Overwrites #1056

Closed
huntabyte opened this issue Apr 29, 2024 · 0 comments · Fixed by #1057
Closed

CLI: Improve UX for Component Overwrites #1056

huntabyte opened this issue Apr 29, 2024 · 0 comments · Fixed by #1057
Labels
type: CLI type: feature Introduction of new functionality to the application

Comments

@huntabyte
Copy link
Owner

Describe the feature

Today, if you add the <Button> to your project and customize it and then later add a component that depends on the <Button>, the contents of the <Button> will be overwritten.

This makes sense, considering we make changes to the component for some dependencies to accommodate a new one. However, we don't give any messaging around this happening.

I'm thinking at the very least, we throw up a confirmation letting the user know - These dependencies will be overwritten, continue (y/n). But the question is, what do we do when they say no, do we not add anything at all? Or do we simply skip updating those dependencies?

Alternatively, we could say something along the lines of Component X depends on components Y, and Z, which you have previously added. These components may have been updated blah blah blah. Do you want to overwrite them now? (y/n) - if the user selects no, then we could say something along the lines of, You've opted not to overwrite these components; please manually diff the latest to ensure you aren't missing any functionality..

The last idea is to let them know that already added components will be overwritten and their git working tree isn't clean, and to ensure they commit beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: CLI type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant