Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong access to plugin states pagination attribute #1074

Closed
Carlos-err406 opened this issue May 5, 2024 · 2 comments · Fixed by #1075
Closed

Wrong access to plugin states pagination attribute #1074

Carlos-err406 opened this issue May 5, 2024 · 2 comments · Fixed by #1075
Assignees
@Carlos-err406
Labels
status: accepted This issue has been accepted and assigned to someone for implementation. type: documentation A change or addition to the documentation

Comments

@Carlos-err406
Copy link
Contributor

Change Type

Correction

Proposed Changes

Current data-table docs section enable-the-addpagination-plugin

line 71, says to access pluginStates.page, but page does not exist in pluginStates, instead seems to have been renamed to pagination

image
@Carlos-err406 Carlos-err406 added the type: documentation A change or addition to the documentation label May 5, 2024
@Carlos-err406
Copy link
Contributor Author

i would gladly open a PR for this

@huntabyte
Copy link
Owner

That would be awesome @Carlos-err406 !

@huntabyte huntabyte added the status: accepted This issue has been accepted and assigned to someone for implementation. label May 5, 2024
@Carlos-err406 Carlos-err406 mentioned this issue May 6, 2024
Merged
@AdrianGonz97 AdrianGonz97 mentioned this issue May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carlos-err406 Carlos-err406

Labels
status: accepted This issue has been accepted and assigned to someone for implementation. type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: pluginState.page is now pluginState.pagination Carlos-err406/shadcn-svelte
2 participants
@huntabyte @Carlos-err406