Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopening with reproduction: Data table becomes empty when email column removed #1117 #1126

Closed
brucegl opened this issue Jun 7, 2024 · 3 comments
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation

Comments

@brucegl
Copy link
Contributor

brucegl commented Jun 7, 2024

Describe the bug

HI,

I followed the guide in the Data Table section and when I hide the email column then all the rows are removed, and the row selection checkbox is checked.

Reproduction

I reproduced this code on Stackblitz here and I added the fix (i.e. adding the line, includeHiddenColumns: true, which is currently commented out)

If you uncomment the line, you can then hide the email column without removing all rows.

Logs

No response

System Info

Stackblitz

Severity

annoyance

@huntabyte huntabyte added status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 8, 2024
@huntabyte
Copy link
Owner

So is this just an issue with the guide? If so, PRs welcome 😃

@brucegl
Copy link
Contributor Author

brucegl commented Jun 10, 2024

Ok, I'll do that now :-)

@brucegl
Copy link
Contributor Author

brucegl commented Jun 10, 2024

submitted PR #1133 to close this

@brucegl brucegl closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation
Projects
None yet
Development

No branches or pull requests

2 participants