Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify @internationalized/date version when installing Calendar components #1208

Open
benbrunyee opened this issue Jul 24, 2024 · 1 comment
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: documentation A change or addition to the documentation

Comments

@benbrunyee
Copy link

Change Type

Correction

Proposed Changes

Currently, under https://www.shadcn-svelte.com/docs/components/calendar#installation it is suggested to install @internationalized/date using npm install bits-ui @internationalized/date.

This can cause type conflicts when using type such as DateValue.
bits-ui includes @internationalized/date as a dependency pinned to a version.
Installing @internationalized/date as currently described in the docs causes type mismatches when working with the Calendar component with classes from @internationalized/date.

I had to run yarn add @internationalized/date@^3.5.1 to fix my type errors.

@benbrunyee benbrunyee added the type: documentation A change or addition to the documentation label Jul 24, 2024
@huntabyte
Copy link
Owner

I think we'll need to make this an optional peer dependency of Bits UI but will defer to someone smarter than me at this @AdrianGonz97

@huntabyte huntabyte added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants