Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Select component shows outdated docs. #1399

Closed
pacosw1 opened this issue Oct 29, 2024 · 2 comments
Closed

The Select component shows outdated docs. #1399

pacosw1 opened this issue Oct 29, 2024 · 2 comments
Labels
type: documentation A change or addition to the documentation

Comments

@pacosw1
Copy link

pacosw1 commented Oct 29, 2024

Change Type

Correction

Proposed Changes

The docs for select show invalid usage of the component.

I added the select component with the CLI but there is no exported type for Select.Value like suggested in the usage. I checked the repo. The previous version does include it but not the next version

New version without the Value type: https://github.com/huntabyte/shadcn-svelte/blob/next/sites/docs/src/lib/registry/new-york/ui/select/index.ts

Old version that includes it https://github.com/huntabyte/shadcn-svelte/blob/main/sites/docs/src/lib/registry/new-york/ui/select/index.ts

@pacosw1 pacosw1 added the type: documentation A change or addition to the documentation label Oct 29, 2024
@shyakadavis
Copy link
Contributor

Was actually about to open a P.R fixing this. Should be only one line removed.

@pacosw1
Copy link
Author

pacosw1 commented Oct 29, 2024

Cool I was just about to use it, but didn't know how it worked.

After some thinkering I saw that type is no longer required, but I thought it was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants