Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide a customised bits.ui Close Button #1433

Closed
1 task done
stefa168 opened this issue Nov 3, 2024 · 1 comment
Closed
1 task done

Ability to provide a customised bits.ui Close Button #1433

stefa168 opened this issue Nov 3, 2024 · 1 comment
Labels
type: feature Introduction of new functionality to the application

Comments

@stefa168
Copy link
Contributor

stefa168 commented Nov 3, 2024

Prerequisites

  • This feature already exists in shadcn/ui - if not, it won't be considered here so don't continue with your issue.

Describe the feature

Hi, I have been working with Dialogs a lot recently, and the current implementation lacks the possibility to provide a custom bits.ui Close button at the top right of the dialog.

A similar issue has been already presented on the original shadcn repo (shadcn-ui/ui#1871).
I'd implement such a change myself, however the current wrapper around bits.ui is a bit out of my league, especially now that Svelte5 has been released and snippets are becoming more and more used.

Is there any way to solve this issue in an elegant way?

@stefa168 stefa168 added the type: feature Introduction of new functionality to the application label Nov 3, 2024
@huntabyte
Copy link
Owner

You can edit the component yourself, the code is yours 😃 as was determined in the original issue you linked. If it is removed there it will be removed here but not until then 😃

@huntabyte huntabyte closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants