Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Svelte 5] Dark mode dropdown example needs to be updated #1441

Closed
hhvrc opened this issue Nov 4, 2024 · 1 comment
Closed

[Svelte 5] Dark mode dropdown example needs to be updated #1441

hhvrc opened this issue Nov 4, 2024 · 1 comment
Labels
type: documentation A change or addition to the documentation

Comments

@hhvrc
Copy link

hhvrc commented Nov 4, 2024

Change Type

Correction

Proposed Changes

https://www.shadcn-svelte.com/docs/dark-mode/svelte#add-a-mode-toggle

The dropdown menu example uses the component let: directive.

In svelte 5 this causes an error:

Svelte error: invalid_default_snippet
Cannot use `{@render children(...)}` if the parent component uses `let:` directives. Consider using a named snippet instead
@hhvrc hhvrc added the type: documentation A change or addition to the documentation label Nov 4, 2024
@hhvrc
Copy link
Author

hhvrc commented Nov 4, 2024

I just realized i linked the old documentation and not the new svelte 5 one, closing issue. 😐

@hhvrc hhvrc closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

1 participant