Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new functionalities #4

Open
9 of 10 tasks
hurielreichel opened this issue Nov 30, 2022 · 5 comments
Open
9 of 10 tasks

new functionalities #4

hurielreichel opened this issue Nov 30, 2022 · 5 comments
Assignees

Comments

@hurielreichel
Copy link
Owner

hurielreichel commented Nov 30, 2022

  • 1. pass .p and .con as function parameters as in Edzer's commit.
  • 2. group_by + summarise behaviour {if data cude is grouped, or not, different interactions} - add new subclass for that and therefore a (sub)method.
  • 3. pass what slice does to filter.
  • 4. year %in% (2000:2002) / group_by(year, month) [use list_connection()$extent as reference
  • 5. check mandatory params -> is.null() stop()
  • 6. "datacube" should be the first in the list of inherits(), not last
  • 7. Maths and Ops Math.datacube = function(x, ...) { p = openeo::processes(); p[.Generic] }
  • 8. Add examples for all functions + add them to the vignette
  • 9. create slice interaction more similar dplyr slice
  • 10. remove default con from all function... speed up code.
@edzer
Copy link
Collaborator

edzer commented Nov 30, 2022

Yes; see also Open-EO/openeo-r-client#141

@hurielreichel
Copy link
Owner Author

Thanks a lot @edzer ! Working on it!

@hurielreichel hurielreichel self-assigned this Dec 1, 2022
@hurielreichel
Copy link
Owner Author

@edzer for number 4, the filter using very dplyrish verbs...

the only way I see this working is to store somehow time related (maybe even space related) objects/columns in the class "datacube". I'd then add "year", "month", "day", "x", "y", create many filter_temporal and filter_spatial and finally use a merge_cubes() process.

What do you think of this idea?

@hurielreichel
Copy link
Owner Author

I'll discuss it with matthias, see if there's a way to do filter_temporal with length > 2 time_ext lists.

hurielreichel added a commit that referenced this issue Feb 19, 2023
hurielreichel added a commit that referenced this issue Apr 30, 2023
@hurielreichel
Copy link
Owner Author

@edzer could you have a look at https://github.com/hurielreichel/tidyopeneo/blob/main/R/Math.R
It's mainly your code, so it would help if you can check it.
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants