-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introductory Offers Not Returning For Subscriptions With StoreKit2 #2471
Comments
@usmanabid94 The issue relates specifically to the introductory offers returning in the JS. My main query here is one of clarification from the maintainers as the two IOS implementations for introductory offers have quite a significant interface difference. |
same here. |
I ended up forking the repo and making a package override as i heard nothing from the maintainers on the issue. As a word of caution i forked from 12.10.5 and there seems to be a few more patches since then. |
I tried to add this and check Any idea on this? |
I had a similar issue as our build process runs the npm install and pod install before bundling to testflight. My best guess would be to check your node_modules and check that the version being used is your custom version and it hasnt pulled the one off the public npm. I think as this problem seems to be hitting a few people I will try and get the change bundled into a PR and get feedback that way |
@Shaw-Signaturize Sure, that would really help Looking forward to your PR |
Cool ill see if i can get to it early next week |
@Shaw-Signaturize Were you able to create PR for this ? |
@Shaw-Signaturize any update on this ? |
@RashVenkat6795 Sorry about the delay. PR: #2630 |
@Shaw-Signaturize thanks for this PR Any possible issues you can think of ? |
Description
When using Ios Storekit1 for retrieving subscriptions, information on the associated introductory offers populates onto the properties
This however does not seem to be the case when using Storekit2 and the properties do not seem to be exposed on any other interface
Expected Behavior
If backwards compatibility is being maintained the properties should populate with the same information
Environment:
To Reproduce
Steps to reproduce the behavior:
[Optional] Additional Context
After debugging it would appear that the issue seems to stem from the function
subscriptionSk2Map
as it is missing property mapping for the introductory properties.Suggested change would be the following if it is to maintain backwards compatibility with
SubscriptionIOS
typeIm happy to create a PR for this but looking to confirm the intent in terms of structure if it is remaining backwards compatible or if it is to follow more closely with the new IOS structure
The text was updated successfully, but these errors were encountered: