Replies: 3 comments 2 replies
-
We should check with @ryscheng if we're enterprise users
Nice idea, could we add this to the GitHub action? Not as a hard fail but we should be alerted on regression in performance. Might be difficult with a fully client side solution tho? Let's also deploy the updated graphs under |
Beta Was this translation helpful? Give feedback.
-
One point that's food for thought ---- Is it possible to keep stronger types whenever possible, i.e. keep it Hypercert IDs in a type {
chainId,
contractAddress,
claimId
} And then have that reflected in various places. For example for a url, we might have We should also be able to query the Graph in a flexible way, for example:
Then leaves the open question, if when would we absolutely need to have a "serialized" format? |
Beta Was this translation helpful? Give feedback.
-
Updated IDs and deployments in: hypercerts-org/hypercerts#1283 |
Beta Was this translation helpful? Give feedback.
-
Summary
Enable querying hypercerts from multiple chains concurrently, using a single SDK
HypercertClient
instance.Abstract
The improvements that are outlined in this proposal will enable
This will create a more cohesive experience when using the frontend, and prevent confusion by end users when browsing hypercerts they own.
Motivation and rationale
The current implementation only allows for querying the chain that the user is currently connected to. Displaying hypercerts from all available chains will clear up confusion for the end user, for example when connected to the wrong chain. It will also enable new users to browse hypercerts without having to connect their wallet before.
Implementation
Graph
hypercerts-org
account so that we can deprecate the hypercerts-admin account: https://thegraph.com/hosted-service/subgraph/hypercerts-org/hypercerts-sepolia.${contractAddress}-${claimId}
to the format of${chainId}-${contractAddress}-${claimId}
. This will ensure that all hypercert ids in the graph remain unique.SDK
"test"
or"production"
parameter, which will determine which chains are queried (test
: sepolia,production
: optimism, celo).signer
(provided at initialization) is connected to.urql
middleware implementation.chainId: number
will be added to the queryParams for all querying methods that return a list of hypercerts.isOnChain(chainId: number, hypercertId: string): boolean
and will be added to the SDK, to make it easy for developers to determine whether the hypercert is on the specified chain.Frontend
Infrastructure
claimId
s in supabase will have to be updated with the chain id. We are already keeping track of this so it can be done using either a simple script, or a single SQL query.Other things to consider:
-
character to obtain either the contract address or hypercert id, as this will not work with the new graph hypercert id format.Operation requirements and ownership
Ownership for this feature will belong to @Jipperism
Links and additional information
Plasmic branching
Example urql middleware implementation:
Known unknowns:
Milestones
Week 1
hypercerts-org
Week 2
Week 3
Week 4
Beta Was this translation helpful? Give feedback.
All reactions