You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So we kinda got screwed a bit recently when the url our client connected to became a https URL. Despite having the crate built with tonics rustls features (tls, tls-roots, tls-webpki-roots) we had to change:
And it's a bit like why doesn't connect just use the default TLS if it's available or return an error if the URL uses HTTPS. Because getting h2 protocol error: http2 error isn't great UX if connect can never work with https just return an error earlier, but I'm of the opinion that the default connect should just work with what's maximally available and cheap to setup by default. Reqwest uses TLS by default so I'm not really seeing a compelling reason for tonic to significantly differ
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
So we kinda got screwed a bit recently when the url our client connected to became a https URL. Despite having the crate built with tonics rustls features (tls, tls-roots, tls-webpki-roots) we had to change:
To:
And it's a bit like why doesn't connect just use the default TLS if it's available or return an error if the URL uses HTTPS. Because getting h2 protocol error: http2 error isn't great UX if connect can never work with https just return an error earlier, but I'm of the opinion that the default connect should just work with what's maximally available and cheap to setup by default. Reqwest uses TLS by default so I'm not really seeing a compelling reason for tonic to significantly differ
Beta Was this translation helpful? Give feedback.
All reactions