-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to get windows 10 "cargo build" and "cargo run" after cloning #238
Comments
So the UDS example will panic on windows since we do not currently support uds through windows as far as I know. I didn't look too deep but it should be easy to port the example.
Good point we should fix this :) I'd accept a PR for this but can do it later as well. |
@LucioFranco I'll take a look at this as well, and see if I can submit a PR with fixes. Let me know if you've already gotten around to this. |
@RetWolf I have not gotten to this exact thing yet but tonic should build on windows. Would love PRs that fix any problem :) |
Ah I see the path problem was already fixed, was hoping to get that easy fix 😛. I've looked briefly over the UDS example, I can try to implement the example for UDS on Windows which was released back towards the end of 2017: https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/ |
@RetWolf great! The issue with windows uds support is that I don't think its upstreamed into tokio so we'd need to get that first. If that is the case then we should open a tracking issue in both tokio/tonic. |
I've created tokio-rs/tokio#2201 in Tokio, if you'd like we can close this issue and create a more explicit issue tracking the feature in Tokio. |
@RetWolf yes that would be perfect! Thank you! Ill close this issue now. |
Tracking ticket created here: #254 |
Ok so I understand if you try to build on windows 10,
it doesn't succeed because of the uds examples.
I simply commented uds-client and uds-server out of the Cargo.toml, then everything builds.
The other thing is the tls example tls-client and tls-server need a tweak to open the correct file path.
Currently the example points to "tonic-examples/data/" but that doesn't exist after cloning.
It needs to be changed to "./examples/data/" to find the .pem/.key files successfully for both the client and the server.
Maybe this will help some others to get this working successfully:
Cheers
The text was updated successfully, but these errors were encountered: