From 3c8404ba25cf3178e20ea56d74488cd272900fa8 Mon Sep 17 00:00:00 2001 From: ashnashahgrover Date: Mon, 22 Jul 2024 19:53:46 +0530 Subject: [PATCH] fix(test-tooling): use of hardcoded password Primary Changes ---------------- 1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function defined in openethereum-test-ledger.ts. It was previously optional. 2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the newEthPersonalAccount function is not hardcoded. Fixes #2766 Signed-off-by: ashnashahgrover --- .../main/typescript/openethereum/openethereum-test-ledger.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cactus-test-tooling/src/main/typescript/openethereum/openethereum-test-ledger.ts b/packages/cactus-test-tooling/src/main/typescript/openethereum/openethereum-test-ledger.ts index f7bf1bf17d7..fe0b86e46ab 100644 --- a/packages/cactus-test-tooling/src/main/typescript/openethereum/openethereum-test-ledger.ts +++ b/packages/cactus-test-tooling/src/main/typescript/openethereum/openethereum-test-ledger.ts @@ -233,7 +233,7 @@ export class OpenEthereumTestLedger { */ public async newEthPersonalAccount( seedMoney = 10e8, - password = "test", + password: string, ): Promise { const account = await this.web3.eth.personal.newAccount(password);