You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If someone is using a dependency in one of the packages and forgets to declare said dependency in the package.json file of that package then the build should detect this and fail accordingly.
The main entrypoint for the custom checks is this file: ./tools/custom-checks/run-custom-checks.ts
Acceptance Criteria
All of the packages are covered in a way that new packages added in the future are also included as they come (e.g. do not hardcode a list of packages to check only the patterns to find them)
The missing packages and the unused ones need to be clearly mentioned in the error messages so that it's trivial to fix the problems highlighted
The CI runs the checks for every pull request
Dev dependencies are ignored, @types/* are ignored
Description
If someone is using a dependency in one of the packages and forgets to declare said dependency in the package.json file of that package then the build should detect this and fail accordingly.
The main entrypoint for the custom checks is this file:
./tools/custom-checks/run-custom-checks.ts
Acceptance Criteria
Hint:
npx dependency-check ./packages/cactus-cmd-api-server/package.json \ --entry ./packages/cactus-cmd-api-server/dist/lib/main/typescript/index.web.js \ --entry ./packages/cactus-cmd-api-server/dist/lib/main/typescript/index.js \ --no-dev \ --ignore-module "@types/*"
The text was updated successfully, but these errors were encountered: