Skip to content

Commit

Permalink
chore(cacti): use lerna 8.1 instead of lerna lite
Browse files Browse the repository at this point in the history
First step of ci refactoring.

Please see ./epics/2024-06-ci-refactoring.md in
this commit for ci refactoring plan.

Primary Change:
 - switch from using lerna lite to lerna 8.1

 Secondary Changes:
 - add ci refactoring plan markdown file
 - lerna.json: remove useWorkspaces, which is not
supported by lerna 8.1
 - introduce package.lock, a new file generated
 - package.json: increase memory used when
   building
 - yarn.lock: introduce lerna 8.1

Signed-off-by: Jennifer Bell <jenniferlianne@gmail.com>
  • Loading branch information
Jennifer Bell committed Aug 2, 2024
1 parent fdce6b3 commit 5d7cf16
Show file tree
Hide file tree
Showing 5 changed files with 174,987 additions and 1,149 deletions.
21 changes: 21 additions & 0 deletions epics/2024-06-ci-refactoring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

# CI Build and Test Refactoring

This epic builds on the proof of concept here: https://github.com/hyperledger/cacti/pull/3348

Intention is to refactor the cacti ci scripts to push logic from ci jobs to commonly defined targets in the base packages, to simplify ci logic and minimize changes to ci when new packages are introduced. These targets may be, for instance:

- test
- build:docker

### Task Breakdown
- [x] Switch from lerna-lite to lerna 8.1 to take advantage of the lerna --since syntax, which unlike 'lerna-lite changed', can use git to compute changed packages. This allows ci to easily identify cascading changes.
- [ ] Programatically refactor ci.yaml:
- [ ] Parse and output ci.yaml with no changes to prepare for programatic changes
- [ ] Add test targets to individual package.json files to run jest and tape tests
- [ ] Add build:docker targets to individual package:json files for scanning in ci
- [ ] Add test:long target (or custom variable?) to individual packages which returns the name of long tests which must be run as individual jobs in ci
- [ ] Integrate weaver packages (TBD)
- [ ] Add package.json and nx.json files to the weaver fabric go SDK so file changes are visible to lerna
- [ ] Expose weaver tests in ci as packages/cacti-test packages

1 change: 0 additions & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
],
"version": "2.0.0-rc.3",
"npmClient": "yarn",
"useWorkspaces": "true",
"command": {
"version": {
"message": "chore(release): publish"
Expand Down
Loading

0 comments on commit 5d7cf16

Please sign in to comment.