Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): make lint script compatible with typescript >=v4.8.0 #2541

Closed
petermetz opened this issue Jul 6, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Member

We had to disable linting [1] entirely when upgrading to Angular v15 (typescript
v4.8.4) because

  1. the older ESLint we have right now does not support typescript versions of >=v4.8.0 AND
  2. the newer ESLint that we COULD upgrade to is broken because it needs our packages to
    be ESM (EcmaScript Modules) which is a big can of worms for now for us to open.

The big picture of the task here is to make yarn lint work again without crashes
and with good results (e.g. the script as it is right now is broken because it
lists hudnreds of false positive linter errors despite our configuration to not
do so)

The solution might be to migrate to ESM (which is long overdue because of how
annoying it is to have dependencies not work because of it).
Other, quick and dirty workarounds MIGHT be acceptible depending on what the
actual trade-offs are in terms of technical debt, performance, developer experience, etc.

[1] #2540

@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Jul 6, 2023
@petermetz petermetz self-assigned this Jul 6, 2023
@petermetz
Copy link
Member Author

This will be fixed by another issue because of cascading dependencies: #1475

@petermetz petermetz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Developer_Experience P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

No branches or pull requests

1 participant