-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade decode-uri-component to >= 0.2.2 #2296
Conversation
bb8924a
to
f6c56af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charellesandig Please upgrade all occurrences of the problematic version of the dependency not just one.
$ npm ls decode-uri-component
@hyperledger/cactus@ /home/peter/a/blockchain/cactus
├─┬ @hyperledger/cactus-cmd-socketio-server@1.1.3 -> ./packages/cactus-cmd-socketio-server
│ └─┬ web3@1.8.2
│ └─┬ web3-bzz@1.8.2
│ └─┬ swarm-js@0.1.40
│ └─┬ xhr-request@1.1.0
│ └─┬ query-string@5.1.1
│ └── decode-uri-component@0.2.2 deduped
├─┬ @hyperledger/cactus-example-supply-chain-frontend@1.1.3 -> ./examples/cactus-example-supply-chain-frontend
│ └─┬ @angular-devkit/build-angular@13.3.5
│ └─┬ stylus@0.56.0
│ └─┬ css@3.0.0
│ └─┬ source-map-resolve@0.6.0
│ └── decode-uri-component@0.2.2 deduped
└─┬ @hyperledger/cactus-test-tooling@1.1.3 -> ./packages/cactus-test-tooling
└─┬ keycloak-admin@1.14.22
└─┬ query-string@6.14.1
└── decode-uri-component@0.2.2
Hi @petermetz , for these packages I upgraded the direct dependencies where
For |
96fd79b
to
8fe661e
Compare
examples/cactus-example-carbon-accounting-frontend/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charellesandig Please see https://github.com/hyperledger/cacti/pull/2296#discussion_r1163124456
Once the dependency has been resolved (e.g. that other issue fixed) then please do the webpack build test again to see if it passes or not. If it does, then just re-request my review and we'll be good to go)
Depends on: #2357 |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
22d9ec6
to
93e46f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't merge until maintainer consensus has been achieved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased onto upstream/main, fixed the merge conflicts and in the meantime Izuru reviewed it too, so we are good to go.
Fixes https://github.com/hyperledger/cacti/issues/2243 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: charelle.sandig <charelle.wrk@gmail.com>
Fixes #2243
Depends on: https://github.com/hyperledger/cacti/issues/2357
Signed-off-by: charellesandig charelle.wrk@gmail.com