Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-htlc-eth-besu): add private HTLCs and forge build & test #2418

Merged
merged 1 commit into from
Jul 3, 2023

Commits on Jul 2, 2023

  1. feat(plugin-htlc-eth-besu): add private HTLCs and forge build & test

    Primary Change:
    ---------------
    
    Adds privacy-preserving HTLCs to the htlc-eth-besu package.
    
    Secondary Change(s):
    -------------------
    
    1. Applied the remappings in the foundry.toml file which is local to the
    package that's being changed. I figured out the parameters by reverse
    engineering the output of `foundry config`
    2. Also removed the remappings.txt file because it is deprecated according
    to the foundry issue tracker on GitHub.
    3. ci(htlc): add foundry setup and tests to the besu HTLC package tests
    4. build(package.json): removed global nohoist, add localized remappings
    5. Modified the withdraw test case[1] so that it uses a hash lock that
    actually works, as-in the newContract call gets the hash of 42 and the
    withdraw call gets 42 (as a left padded hex, but otherwise unencoded)
    
    [1]: packages/cactus-test-plugin-htlc-eth-besu/src/test/typescript/
    integration/plugin-htlc-eth-besu/withdraw-endpoint.test.ts
    
    Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    
    Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    RafaelAPB authored and petermetz committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    151191a View commit details
    Browse the repository at this point in the history