docs(examples): upgrade Angular to v14 #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Upgraded Angular from v13 to v14 2. Also bumped up the Ionic Framework dependencies as needed because older versions that we were using were not compatible [1] with Angular v14 3. Also did some of the Cactus -> Cacti renaming in the front-end code namely the front-page of both the supply chain and the carbon accounting app examples. [1] https://stackoverflow.com/a/72508644 Verbatim copy of the above link's comment: ================================== The current version of Ionic v6.1.8 is not compatible with Angular 14. Apparently, it's been fixed in a dev release but it's not stable yet. Have a look here ionic-team/ionic-framework#25353 you can update @ionic/angular to version 6.1.9-dev.11654275237.1b595be3 and re-run npm install. Should work fine for now, if you wanna be on the edge. ================================== Fixes hyperledger-cacti#2377 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Jun 30, 2023
takeutak
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as needed because older versions that we were using
were not compatible [1] with Angular v14
in the front-end code namely the front-page of
both the supply chain and the carbon accounting
app examples.
[1] https://stackoverflow.com/a/72508644
Verbatim copy of the above link's comment:
==================================
The current version of Ionic v6.1.8 is not
compatible with Angular 14. Apparently,
it's been fixed in a dev release but it's not
stable yet. Have a look here
ionic-team/ionic-framework#25353
you can update @ionic/angular to
version 6.1.9-dev.11654275237.1b595be3
and re-run npm install.
Should work fine for now, if you wanna be on the edge.
==================================
Fixes #2377
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com