ci(tools/docker): stop compiling Iroha as part of the all-in-one image build #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Jul 18, 2023
…e build 1. Upgraded the Iroha AIO image to use v1.4.0-patch-3 2. The new Iroha version now supports configuraton via ENV variables 3. Because of 2) we don't need to apply config file changes in the entrypoint script of the container anymore, yay. 4. The new image uses the iroha release image as the base and it does NOT recompile the entire project which makes the build orders of magnitude faster, wasting much less CI time/resources. 5. Exposed the healthcheck port for through the IrohaTestLedger class so the other improvement we'll be able to do after this is to phase out the hacky python script that does the healthcheck at the moment if the new built-in healthcheck endpoint does actually work fine. 6. Migrated all the test cases to the new image version. Fixes hyperledger-cacti#2524 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2524
branch
from
3d70107
to
4bb0493
Compare
auto-merge was automatically disabled
July 21, 2023 21:25
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypoint script of the container anymore, yay.
does NOT recompile the entire project which makes the build
orders of magnitude faster, wasting much less CI time/resources.
so the other improvement we'll be able to do after this is to phase out
the hacky python script that does the healthcheck at the moment if
the new built-in healthcheck endpoint does actually work fine.
Fixes #2524
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com