test(weaver): added missed fabric-ca-server config #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepnRES
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
outSH
as code owners
VRamakrishna
approved these changes
Jun 14, 2024
outSH
approved these changes
Jun 14, 2024
petermetz
approved these changes
Jun 14, 2024
petermetz
reviewed
Jun 14, 2024
There was a problem hiding this comment.
@sandeepnRES A couple of them are still failing unfortunately :-(
Test Asset Exchange Fabric / asset-exchange-fabric-local (pull_request) Failing after 6m
Test Asset Transfer / asset-transfer-local (pull_request) Failing after 13m
It seems the fabric certificates for test network have expired, will re-issue them in this PR only. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/ordererOrg/msp/keystore/IssuerRevocationPrivateKey | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/e0bb716cebcf677420bd2d99f3159d96005d6c8311923d45a9fe3938714f043d_sk | View secret | |
| 5633830 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/orderers/orderer.network1.com/msp/keystore/4e8886ce82fb88288e2c8979f42668f96cac7c553a6868dcb3ab77759b726c87_sk | View secret |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/alice.id | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/core/drivers/fabric-driver/wallet-network1/relay.id | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/core/drivers/fabric-driver/wallet-network2/relay.id | View secret | |
| 5633826 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/158fc87aebce575beac99afb75dc785628fa53d542cf06a6dcba9f3ff7cbd141_sk | View secret |
| 5633835 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/networkadmin.id | View secret |
| 5633816 | Triggered | Generic Private Key | e57c9d7 | weaver/core/drivers/fabric-driver/wallet-network1/relay.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/networkadmin.id | View secret | |
| 5633825 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org1/msp/keystore/c3ecc43c773376bd65d08f398b24efc998a306254c3162722b7076425b06a952_sk | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/ordererOrg/msp/keystore/0cedcb25220cd4268fa66bfbd1fe596d26372bd5bebbd740fb3e140de597ba61_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/10904f97b1846924769fda627f2d4e7924f904377ea4313e68cf5be7e165bbf9_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org1/msp/keystore/IssuerRevocationPrivateKey | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/ordererOrg/msp/keystore/a18027cd218b71ae733f80c45f9b9bc12fd6cb5997f9d5c54bfb62f7e12a6c86_sk | View secret | |
| 5633819 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/user1.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/orderers/orderer.network1.com/msp/keystore/af3519264abbc0d1604769f3a7a0f2659f27037e13a92f05d4405424b6d58b23_sk | View secret | |
| 5633823 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org1/msp/keystore/21f77749869bc4614a6fd88556c1a4b4da94a351160c60b57666324e973527f8_sk | View secret |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/user1.id | View secret | |
| 5633836 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/networkadmin.id | View secret |
| 5633827 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/58d85ba0c547563cc52522c445ee5e1eb1e3c66c2611297cfb116877ee8d30fa_sk | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/users/Admin@network1.com/msp/keystore/86b5561d6e113f4bef690c880a2c783c467e0a009bfc9a0cf4bdb790c6e03e3c_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org1/msp/keystore/a6ca52b519199223f12b72c54944ce32628f34de382e118e6a7cf9737394fb45_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/user1.id | View secret | |
| 6841176 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/alice.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org1/msp/keystore/a7fa347b343cb9b9d4f13fade85803d6c19a0e83fb628c636530a39c4fbc2585_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/networkadmin.id | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/msp/keystore/b9fe0ac93ce784d94cc81b9605e7498eb7574adee1987da15e8e6e8d9aeeae1e_sk | View secret | |
| 6841179 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/bob.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/bob.id | View secret | |
| 6841177 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/bob.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/898d38723f793d23652de12e3ce50fb9b93ba60b44b3a360f3fb7aa77fcbe9bd_sk | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/IssuerRevocationPrivateKey | View secret | |
| 6841178 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/alice.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/orderers/orderer.network1.com/tls/server.key | View secret | |
| 5633820 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/ordererOrg/msp/keystore/5e01605d4d48b33b11d0a1687849c5cdc93f7c8bae889fcedcdf96c057321032_sk | View secret |
| 5633832 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/users/Admin@network1.com/msp/keystore/ea6774918dd9633c681f17c9d7b63fb9d85b66d5e5c6beb50f62572fc01fea5d_sk | View secret |
| 5633822 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/ordererOrg/msp/keystore/f6932e894b1bb73e044b6d9db4086a7b0d141749adbc6a339ffbc4cb160eaf68_sk | View secret |
| 5633818 | Triggered | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network1/user1.id | View secret |
| 5633829 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/msp/keystore/17969b1a79d80ad17b0db83b7277cda18104234c9007eb145f4b21dc4ac82ae4_sk | View secret |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/bob.id | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/samples/fabric/fabric-cli/src/wallet-network2/alice.id | View secret | |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/fabric-ca/org2/msp/keystore/1f7f837d253bc4d691e1f7de2b740e355f1a05daa99cde1d7b914b5e4321e0c9_sk | View secret | |
| 5633831 | Triggered | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/orderers/orderer.network1.com/tls/keystore/1c008ae138e299c2ecc31763b35bae18579810a6936f27af0fd15b32fc1a10dc_sk | View secret |
| 5633817 | Triggered | Generic Private Key | e57c9d7 | weaver/core/drivers/fabric-driver/wallet-network2/relay.id | View secret |
| - | Generic Private Key | e57c9d7 | weaver/tests/network-setups/fabric/network-artifacts/network1/ordererOrganizations/network1.com/orderers/orderer.network1.com/tls/keystore/6a9aaba6b033b23880b510e1010d4c19d4e87471a68978528175a82c1f97e9e8_sk | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
sandeepnRES
force-pushed
the
main
branch
2 times, most recently
from
51f73af
to
b879518
Compare
5 tasks
petermetz
requested changes
Jun 18, 2024
There was a problem hiding this comment.
@sandeepnRES Please squash the commits together if possible
- to extend cert expiry to 10 years
- re-generate expired fabric testnet certs
- update readme for re-generation to add missing steps
Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Done. |
petermetz
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files were missed when we were merging Weaver into Cacti, due to a wrong
.gitignore. It also extends expiry of certs to 10 years.test(weaver): re-generate expired fabric testnet certs
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit